-
Notifications
You must be signed in to change notification settings - Fork 324
Add safety check for TargetSystem encoding limits #10451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
approved these changes
Jan 27, 2026
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~ba99e03364, baseline=1.59.0-SNAPSHOT~c5c0d11f32
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057092
Total [baseline] (8.673 s) : 0, 8673046
Agent [candidate] (1.06 s) : 0, 1059764
Total [candidate] (8.688 s) : 0, 8688416
section iast
Agent [baseline] (1.223 s) : 0, 1223442
Total [baseline] (9.339 s) : 0, 9339163
Agent [candidate] (1.232 s) : 0, 1232083
Total [candidate] (9.378 s) : 0, 9377671
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~ba99e03364, baseline=1.59.0-SNAPSHOT~c5c0d11f32
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (622.822 ms) : 0, 622822
BytebuddyAgent [candidate] (623.403 ms) : 0, 623403
AgentMeter [baseline] (28.716 ms) : 0, 28716
AgentMeter [candidate] (28.798 ms) : 0, 28798
GlobalTracer [baseline] (257.088 ms) : 0, 257088
GlobalTracer [candidate] (257.369 ms) : 0, 257369
AppSec [baseline] (32.913 ms) : 0, 32913
AppSec [candidate] (32.685 ms) : 0, 32685
Debugger [baseline] (61.64 ms) : 0, 61640
Debugger [candidate] (60.142 ms) : 0, 60142
Remote Config [baseline] (624.842 µs) : 0, 625
Remote Config [candidate] (617.719 µs) : 0, 618
Telemetry [baseline] (9.059 ms) : 0, 9059
Telemetry [candidate] (10.584 ms) : 0, 10584
Flare Poller [baseline] (7.621 ms) : 0, 7621
Flare Poller [candidate] (9.504 ms) : 0, 9504
section iast
crashtracking [baseline] (1.174 ms) : 0, 1174
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (789.558 ms) : 0, 789558
BytebuddyAgent [candidate] (795.784 ms) : 0, 795784
AgentMeter [baseline] (11.153 ms) : 0, 11153
AgentMeter [candidate] (11.212 ms) : 0, 11212
GlobalTracer [baseline] (247.346 ms) : 0, 247346
GlobalTracer [candidate] (249.256 ms) : 0, 249256
IAST [baseline] (26.864 ms) : 0, 26864
IAST [candidate] (27.098 ms) : 0, 27098
AppSec [baseline] (32.128 ms) : 0, 32128
AppSec [candidate] (34.58 ms) : 0, 34580
Debugger [baseline] (67.568 ms) : 0, 67568
Debugger [candidate] (64.968 ms) : 0, 64968
Remote Config [baseline] (550.642 µs) : 0, 551
Remote Config [candidate] (548.117 µs) : 0, 548
Telemetry [baseline] (8.433 ms) : 0, 8433
Telemetry [candidate] (8.492 ms) : 0, 8492
Flare Poller [baseline] (3.406 ms) : 0, 3406
Flare Poller [candidate] (3.467 ms) : 0, 3467
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~ba99e03364, baseline=1.59.0-SNAPSHOT~c5c0d11f32
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1078435
Total [baseline] (11.076 s) : 0, 11075545
Agent [candidate] (1.064 s) : 0, 1063806
Total [candidate] (10.994 s) : 0, 10993507
section appsec
Agent [baseline] (1.238 s) : 0, 1238477
Total [baseline] (10.982 s) : 0, 10981831
Agent [candidate] (1.237 s) : 0, 1236684
Total [candidate] (11.095 s) : 0, 11094878
section iast
Agent [baseline] (1.224 s) : 0, 1223924
Total [baseline] (11.106 s) : 0, 11106309
Agent [candidate] (1.226 s) : 0, 1226067
Total [candidate] (11.122 s) : 0, 11122021
section profiling
Agent [baseline] (1.184 s) : 0, 1183595
Total [baseline] (10.892 s) : 0, 10892268
Agent [candidate] (1.193 s) : 0, 1192769
Total [candidate] (10.923 s) : 0, 10923092
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~ba99e03364, baseline=1.59.0-SNAPSHOT~c5c0d11f32
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (635.736 ms) : 0, 635736
BytebuddyAgent [candidate] (625.705 ms) : 0, 625705
AgentMeter [baseline] (29.222 ms) : 0, 29222
AgentMeter [candidate] (28.986 ms) : 0, 28986
GlobalTracer [baseline] (260.155 ms) : 0, 260155
GlobalTracer [candidate] (258.481 ms) : 0, 258481
AppSec [baseline] (33.617 ms) : 0, 33617
AppSec [candidate] (33.072 ms) : 0, 33072
Debugger [baseline] (62.059 ms) : 0, 62059
Debugger [candidate] (63.607 ms) : 0, 63607
Remote Config [baseline] (633.903 µs) : 0, 634
Remote Config [candidate] (634.083 µs) : 0, 634
Telemetry [baseline] (9.998 ms) : 0, 9998
Telemetry [candidate] (10.684 ms) : 0, 10684
Flare Poller [baseline] (10.073 ms) : 0, 10073
Flare Poller [candidate] (5.984 ms) : 0, 5984
section appsec
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (655.785 ms) : 0, 655785
BytebuddyAgent [candidate] (653.848 ms) : 0, 653848
AgentMeter [baseline] (11.988 ms) : 0, 11988
AgentMeter [candidate] (11.922 ms) : 0, 11922
GlobalTracer [baseline] (258.38 ms) : 0, 258380
GlobalTracer [candidate] (258.594 ms) : 0, 258594
IAST [baseline] (25.672 ms) : 0, 25672
IAST [candidate] (25.62 ms) : 0, 25620
AppSec [baseline] (168.25 ms) : 0, 168250
AppSec [candidate] (168.467 ms) : 0, 168467
Debugger [baseline] (68.101 ms) : 0, 68101
Debugger [candidate] (68.108 ms) : 0, 68108
Remote Config [baseline] (692.018 µs) : 0, 692
Remote Config [candidate] (688.427 µs) : 0, 688
Telemetry [baseline] (9.276 ms) : 0, 9276
Telemetry [candidate] (9.325 ms) : 0, 9325
Flare Poller [baseline] (3.69 ms) : 0, 3690
Flare Poller [candidate] (3.693 ms) : 0, 3693
section iast
crashtracking [baseline] (1.164 ms) : 0, 1164
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (788.509 ms) : 0, 788509
BytebuddyAgent [candidate] (789.938 ms) : 0, 789938
AgentMeter [baseline] (11.109 ms) : 0, 11109
AgentMeter [candidate] (11.128 ms) : 0, 11128
GlobalTracer [baseline] (247.675 ms) : 0, 247675
GlobalTracer [candidate] (248.082 ms) : 0, 248082
IAST [baseline] (26.888 ms) : 0, 26888
IAST [candidate] (26.962 ms) : 0, 26962
AppSec [baseline] (32.227 ms) : 0, 32227
AppSec [candidate] (31.416 ms) : 0, 31416
Debugger [baseline] (68.436 ms) : 0, 68436
Debugger [candidate] (69.43 ms) : 0, 69430
Remote Config [baseline] (547.465 µs) : 0, 547
Remote Config [candidate] (541.541 µs) : 0, 542
Telemetry [baseline] (8.556 ms) : 0, 8556
Telemetry [candidate] (8.548 ms) : 0, 8548
Flare Poller [baseline] (3.496 ms) : 0, 3496
Flare Poller [candidate] (3.456 ms) : 0, 3456
section profiling
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.233 ms) : 0, 1233
BytebuddyAgent [baseline] (675.969 ms) : 0, 675969
BytebuddyAgent [candidate] (682.123 ms) : 0, 682123
AgentMeter [baseline] (8.631 ms) : 0, 8631
AgentMeter [candidate] (8.714 ms) : 0, 8714
GlobalTracer [baseline] (216.291 ms) : 0, 216291
GlobalTracer [candidate] (218.205 ms) : 0, 218205
AppSec [baseline] (32.375 ms) : 0, 32375
AppSec [candidate] (32.68 ms) : 0, 32680
Debugger [baseline] (67.63 ms) : 0, 67630
Debugger [candidate] (67.9 ms) : 0, 67900
Remote Config [baseline] (584.613 µs) : 0, 585
Remote Config [candidate] (604.842 µs) : 0, 605
Telemetry [baseline] (8.619 ms) : 0, 8619
Telemetry [candidate] (8.757 ms) : 0, 8757
Flare Poller [baseline] (3.695 ms) : 0, 3695
Flare Poller [candidate] (3.724 ms) : 0, 3724
ProfilingAgent [baseline] (98.878 ms) : 0, 98878
ProfilingAgent [candidate] (98.64 ms) : 0, 98640
Profiling [baseline] (99.46 ms) : 0, 99460
Profiling [candidate] (99.209 ms) : 0, 99209
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 19 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~ba99e03364, baseline=1.59.0-SNAPSHOT~c5c0d11f32
dateFormat X
axisFormat %s
section baseline
no_agent (18.132 ms) : 17948, 18316
. : milestone, 18132,
appsec (18.982 ms) : 18789, 19175
. : milestone, 18982,
code_origins (17.755 ms) : 17577, 17933
. : milestone, 17755,
iast (17.792 ms) : 17612, 17972
. : milestone, 17792,
profiling (18.536 ms) : 18353, 18719
. : milestone, 18536,
tracing (17.868 ms) : 17692, 18045
. : milestone, 17868,
section candidate
no_agent (19.2 ms) : 19005, 19395
. : milestone, 19200,
appsec (18.648 ms) : 18460, 18835
. : milestone, 18648,
code_origins (17.713 ms) : 17537, 17889
. : milestone, 17713,
iast (17.749 ms) : 17574, 17923
. : milestone, 17749,
profiling (18.932 ms) : 18742, 19123
. : milestone, 18932,
tracing (17.714 ms) : 17534, 17895
. : milestone, 17714,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~ba99e03364, baseline=1.59.0-SNAPSHOT~c5c0d11f32
dateFormat X
axisFormat %s
section baseline
no_agent (1.17 ms) : 1158, 1181
. : milestone, 1170,
iast (3.158 ms) : 3118, 3199
. : milestone, 3158,
iast_FULL (5.859 ms) : 5800, 5917
. : milestone, 5859,
iast_GLOBAL (3.517 ms) : 3467, 3567
. : milestone, 3517,
profiling (2.14 ms) : 2121, 2160
. : milestone, 2140,
tracing (1.821 ms) : 1805, 1837
. : milestone, 1821,
section candidate
no_agent (1.189 ms) : 1177, 1201
. : milestone, 1189,
iast (3.14 ms) : 3095, 3185
. : milestone, 3140,
iast_FULL (5.688 ms) : 5631, 5744
. : milestone, 5688,
iast_GLOBAL (3.603 ms) : 3550, 3656
. : milestone, 3603,
profiling (2.119 ms) : 2100, 2137
. : milestone, 2119,
tracing (1.774 ms) : 1759, 1788
. : milestone, 1774,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~ba99e03364, baseline=1.59.0-SNAPSHOT~c5c0d11f32
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1480
. : milestone, 1469,
appsec (3.674 ms) : 3459, 3889
. : milestone, 3674,
iast (2.24 ms) : 2171, 2309
. : milestone, 2240,
iast_GLOBAL (2.293 ms) : 2224, 2363
. : milestone, 2293,
profiling (2.089 ms) : 2033, 2146
. : milestone, 2089,
tracing (2.052 ms) : 1999, 2105
. : milestone, 2052,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.714 ms) : 3494, 3934
. : milestone, 3714,
iast (2.249 ms) : 2180, 2318
. : milestone, 2249,
iast_GLOBAL (2.289 ms) : 2219, 2358
. : milestone, 2289,
profiling (2.495 ms) : 2279, 2711
. : milestone, 2495,
tracing (2.047 ms) : 1994, 2100
. : milestone, 2047,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~ba99e03364, baseline=1.59.0-SNAPSHOT~c5c0d11f32
dateFormat X
axisFormat %s
section baseline
no_agent (15.624 s) : 15624000, 15624000
. : milestone, 15624000,
appsec (14.814 s) : 14814000, 14814000
. : milestone, 14814000,
iast (18.49 s) : 18490000, 18490000
. : milestone, 18490000,
iast_GLOBAL (17.592 s) : 17592000, 17592000
. : milestone, 17592000,
profiling (14.945 s) : 14945000, 14945000
. : milestone, 14945000,
tracing (14.472 s) : 14472000, 14472000
. : milestone, 14472000,
section candidate
no_agent (15.371 s) : 15371000, 15371000
. : milestone, 15371000,
appsec (14.764 s) : 14764000, 14764000
. : milestone, 14764000,
iast (18.568 s) : 18568000, 18568000
. : milestone, 18568000,
iast_GLOBAL (17.736 s) : 17736000, 17736000
. : milestone, 17736000,
profiling (15.44 s) : 15440000, 15440000
. : milestone, 15440000,
tracing (14.739 s) : 14739000, 14739000
. : milestone, 14739000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Allows to have TargetSystem encoding in InstrumenterIndex future proof
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]