-
Notifications
You must be signed in to change notification settings - Fork 324
Move pure context tracking instrumenter to InstrumenterModule.ContexTracking #10425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e073737 to
312376e
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 13 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~4a44ebe3a8, baseline=1.59.0-SNAPSHOT~a25afafa07
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1067837
Total [baseline] (10.947 s) : 0, 10947352
Agent [candidate] (1.063 s) : 0, 1062767
Total [candidate] (10.947 s) : 0, 10946905
section appsec
Agent [baseline] (1.248 s) : 0, 1248101
Total [baseline] (11.076 s) : 0, 11075644
Agent [candidate] (1.231 s) : 0, 1231192
Total [candidate] (11.089 s) : 0, 11088923
section iast
Agent [baseline] (1.237 s) : 0, 1236865
Total [baseline] (11.157 s) : 0, 11156814
Agent [candidate] (1.234 s) : 0, 1234480
Total [candidate] (11.144 s) : 0, 11144151
section profiling
Agent [baseline] (1.185 s) : 0, 1184984
Total [baseline] (10.865 s) : 0, 10865432
Agent [candidate] (1.185 s) : 0, 1184997
Total [candidate] (10.907 s) : 0, 10907286
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~4a44ebe3a8, baseline=1.59.0-SNAPSHOT~a25afafa07
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (627.655 ms) : 0, 627655
BytebuddyAgent [candidate] (624.066 ms) : 0, 624066
AgentMeter [baseline] (29.015 ms) : 0, 29015
AgentMeter [candidate] (28.889 ms) : 0, 28889
GlobalTracer [baseline] (259.841 ms) : 0, 259841
GlobalTracer [candidate] (257.862 ms) : 0, 257862
AppSec [baseline] (33.395 ms) : 0, 33395
AppSec [candidate] (32.972 ms) : 0, 32972
Debugger [baseline] (62.827 ms) : 0, 62827
Debugger [candidate] (63.885 ms) : 0, 63885
Remote Config [baseline] (636.541 µs) : 0, 637
Remote Config [candidate] (628.093 µs) : 0, 628
Telemetry [baseline] (11.523 ms) : 0, 11523
Telemetry [candidate] (10.927 ms) : 0, 10927
Flare Poller [baseline] (6.069 ms) : 0, 6069
Flare Poller [candidate] (6.89 ms) : 0, 6890
section appsec
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (661.073 ms) : 0, 661073
BytebuddyAgent [candidate] (651.322 ms) : 0, 651322
AgentMeter [baseline] (12.045 ms) : 0, 12045
AgentMeter [candidate] (11.884 ms) : 0, 11884
GlobalTracer [baseline] (260.79 ms) : 0, 260790
GlobalTracer [candidate] (257.245 ms) : 0, 257245
IAST [baseline] (25.945 ms) : 0, 25945
IAST [candidate] (25.501 ms) : 0, 25501
AppSec [baseline] (169.359 ms) : 0, 169359
AppSec [candidate] (167.375 ms) : 0, 167375
Debugger [baseline] (68.188 ms) : 0, 68188
Debugger [candidate] (67.652 ms) : 0, 67652
Remote Config [baseline] (696.135 µs) : 0, 696
Remote Config [candidate] (683.882 µs) : 0, 684
Telemetry [baseline] (9.382 ms) : 0, 9382
Telemetry [candidate] (9.319 ms) : 0, 9319
Flare Poller [baseline] (3.741 ms) : 0, 3741
Flare Poller [candidate] (3.681 ms) : 0, 3681
section iast
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (797.819 ms) : 0, 797819
BytebuddyAgent [candidate] (796.123 ms) : 0, 796123
AgentMeter [baseline] (11.451 ms) : 0, 11451
AgentMeter [candidate] (11.422 ms) : 0, 11422
GlobalTracer [baseline] (250.326 ms) : 0, 250326
GlobalTracer [candidate] (248.892 ms) : 0, 248892
IAST [baseline] (27.178 ms) : 0, 27178
IAST [candidate] (27.163 ms) : 0, 27163
AppSec [baseline] (34.798 ms) : 0, 34798
AppSec [candidate] (32.31 ms) : 0, 32310
Debugger [baseline] (65.855 ms) : 0, 65855
Debugger [candidate] (69.006 ms) : 0, 69006
Remote Config [baseline] (544.423 µs) : 0, 544
Remote Config [candidate] (552.524 µs) : 0, 553
Telemetry [baseline] (8.57 ms) : 0, 8570
Telemetry [candidate] (8.696 ms) : 0, 8696
Flare Poller [baseline] (3.454 ms) : 0, 3454
Flare Poller [candidate] (3.547 ms) : 0, 3547
section profiling
crashtracking [baseline] (1.221 ms) : 0, 1221
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (676.452 ms) : 0, 676452
BytebuddyAgent [candidate] (676.64 ms) : 0, 676640
AgentMeter [baseline] (8.676 ms) : 0, 8676
AgentMeter [candidate] (8.662 ms) : 0, 8662
GlobalTracer [baseline] (216.65 ms) : 0, 216650
GlobalTracer [candidate] (216.061 ms) : 0, 216061
AppSec [baseline] (32.252 ms) : 0, 32252
AppSec [candidate] (32.214 ms) : 0, 32214
Debugger [baseline] (67.78 ms) : 0, 67780
Debugger [candidate] (67.248 ms) : 0, 67248
Remote Config [baseline] (589.43 µs) : 0, 589
Remote Config [candidate] (611.432 µs) : 0, 611
Telemetry [baseline] (8.787 ms) : 0, 8787
Telemetry [candidate] (8.762 ms) : 0, 8762
Flare Poller [baseline] (3.8 ms) : 0, 3800
Flare Poller [candidate] (3.698 ms) : 0, 3698
ProfilingAgent [baseline] (98.901 ms) : 0, 98901
ProfilingAgent [candidate] (99.978 ms) : 0, 99978
Profiling [baseline] (99.472 ms) : 0, 99472
Profiling [candidate] (100.552 ms) : 0, 100552
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~4a44ebe3a8, baseline=1.59.0-SNAPSHOT~a25afafa07
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056004
Total [baseline] (8.733 s) : 0, 8733313
Agent [candidate] (1.064 s) : 0, 1064251
Total [candidate] (8.716 s) : 0, 8715810
section iast
Agent [baseline] (1.222 s) : 0, 1221888
Total [baseline] (9.313 s) : 0, 9312962
Agent [candidate] (1.233 s) : 0, 1233397
Total [candidate] (9.384 s) : 0, 9383591
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~4a44ebe3a8, baseline=1.59.0-SNAPSHOT~a25afafa07
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (621.752 ms) : 0, 621752
BytebuddyAgent [candidate] (628.095 ms) : 0, 628095
AgentMeter [baseline] (28.67 ms) : 0, 28670
AgentMeter [candidate] (29.051 ms) : 0, 29051
GlobalTracer [baseline] (257.646 ms) : 0, 257646
GlobalTracer [candidate] (258.064 ms) : 0, 258064
AppSec [baseline] (32.83 ms) : 0, 32830
AppSec [candidate] (32.82 ms) : 0, 32820
Debugger [baseline] (61.692 ms) : 0, 61692
Debugger [candidate] (62.048 ms) : 0, 62048
Remote Config [baseline] (683.621 µs) : 0, 684
Remote Config [candidate] (619.306 µs) : 0, 619
Telemetry [baseline] (9.977 ms) : 0, 9977
Telemetry [candidate] (9.818 ms) : 0, 9818
Flare Poller [baseline] (6.025 ms) : 0, 6025
Flare Poller [candidate] (6.815 ms) : 0, 6815
section iast
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (787.804 ms) : 0, 787804
BytebuddyAgent [candidate] (796.902 ms) : 0, 796902
AgentMeter [baseline] (11.185 ms) : 0, 11185
AgentMeter [candidate] (11.414 ms) : 0, 11414
GlobalTracer [baseline] (247.86 ms) : 0, 247860
GlobalTracer [candidate] (248.361 ms) : 0, 248361
IAST [baseline] (26.746 ms) : 0, 26746
IAST [candidate] (26.857 ms) : 0, 26857
AppSec [baseline] (34.46 ms) : 0, 34460
AppSec [candidate] (34.248 ms) : 0, 34248
Debugger [baseline] (64.753 ms) : 0, 64753
Debugger [candidate] (66.19 ms) : 0, 66190
Remote Config [baseline] (555.021 µs) : 0, 555
Remote Config [candidate] (550.529 µs) : 0, 551
Telemetry [baseline] (8.559 ms) : 0, 8559
Telemetry [candidate] (8.612 ms) : 0, 8612
Flare Poller [baseline] (3.43 ms) : 0, 3430
Flare Poller [candidate] (3.486 ms) : 0, 3486
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 20 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~4a44ebe3a8, baseline=1.59.0-SNAPSHOT~a25afafa07
dateFormat X
axisFormat %s
section baseline
no_agent (1.191 ms) : 1179, 1204
. : milestone, 1191,
iast (3.253 ms) : 3210, 3296
. : milestone, 3253,
iast_FULL (5.781 ms) : 5724, 5837
. : milestone, 5781,
iast_GLOBAL (3.662 ms) : 3599, 3725
. : milestone, 3662,
profiling (2.193 ms) : 2173, 2213
. : milestone, 2193,
tracing (1.891 ms) : 1875, 1907
. : milestone, 1891,
section candidate
no_agent (1.192 ms) : 1179, 1205
. : milestone, 1192,
iast (3.175 ms) : 3134, 3215
. : milestone, 3175,
iast_FULL (5.92 ms) : 5860, 5980
. : milestone, 5920,
iast_GLOBAL (3.667 ms) : 3606, 3729
. : milestone, 3667,
profiling (2.181 ms) : 2161, 2202
. : milestone, 2181,
tracing (1.841 ms) : 1826, 1855
. : milestone, 1841,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~4a44ebe3a8, baseline=1.59.0-SNAPSHOT~a25afafa07
dateFormat X
axisFormat %s
section baseline
no_agent (19.177 ms) : 18980, 19373
. : milestone, 19177,
appsec (18.887 ms) : 18696, 19079
. : milestone, 18887,
code_origins (17.515 ms) : 17341, 17689
. : milestone, 17515,
iast (17.794 ms) : 17618, 17969
. : milestone, 17794,
profiling (18.507 ms) : 18321, 18693
. : milestone, 18507,
tracing (17.738 ms) : 17559, 17918
. : milestone, 17738,
section candidate
no_agent (18.379 ms) : 18186, 18571
. : milestone, 18379,
appsec (19.056 ms) : 18861, 19250
. : milestone, 19056,
code_origins (17.708 ms) : 17533, 17882
. : milestone, 17708,
iast (17.817 ms) : 17639, 17995
. : milestone, 17817,
profiling (18.63 ms) : 18445, 18816
. : milestone, 18630,
tracing (17.703 ms) : 17529, 17876
. : milestone, 17703,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~4a44ebe3a8, baseline=1.59.0-SNAPSHOT~a25afafa07
dateFormat X
axisFormat %s
section baseline
no_agent (14.73 s) : 14730000, 14730000
. : milestone, 14730000,
appsec (15.005 s) : 15005000, 15005000
. : milestone, 15005000,
iast (18.127 s) : 18127000, 18127000
. : milestone, 18127000,
iast_GLOBAL (17.698 s) : 17698000, 17698000
. : milestone, 17698000,
profiling (14.879 s) : 14879000, 14879000
. : milestone, 14879000,
tracing (14.745 s) : 14745000, 14745000
. : milestone, 14745000,
section candidate
no_agent (15.471 s) : 15471000, 15471000
. : milestone, 15471000,
appsec (14.621 s) : 14621000, 14621000
. : milestone, 14621000,
iast (18.296 s) : 18296000, 18296000
. : milestone, 18296000,
iast_GLOBAL (17.956 s) : 17956000, 17956000
. : milestone, 17956000,
profiling (14.885 s) : 14885000, 14885000
. : milestone, 14885000,
tracing (14.638 s) : 14638000, 14638000
. : milestone, 14638000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~4a44ebe3a8, baseline=1.59.0-SNAPSHOT~a25afafa07
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.74 ms) : 3516, 3965
. : milestone, 3740,
iast (2.265 ms) : 2195, 2335
. : milestone, 2265,
iast_GLOBAL (2.3 ms) : 2230, 2371
. : milestone, 2300,
profiling (2.117 ms) : 2059, 2174
. : milestone, 2117,
tracing (2.064 ms) : 2010, 2117
. : milestone, 2064,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.551 ms) : 2492, 2610
. : milestone, 2551,
iast (2.26 ms) : 2190, 2330
. : milestone, 2260,
iast_GLOBAL (2.305 ms) : 2234, 2375
. : milestone, 2305,
profiling (2.089 ms) : 2033, 2144
. : milestone, 2089,
tracing (2.074 ms) : 2019, 2128
. : milestone, 2074,
|
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks for the refactoring. Left one question
...main/java/datadog/trace/instrumentation/akka/concurrent/AkkaForkJoinPoolInstrumentation.java
Outdated
Show resolved
Hide resolved
ebf97b9 to
1fb6c79
Compare
1fb6c79 to
59553c5
Compare
59553c5 to
6227343
Compare
6227343 to
4a44ebe
Compare
What Does This Do
Change target system to
ContextTrackingfor InstrumenterModule that only capture/restore states.Additional changes:
There are still few others to refactor like:
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]