Skip to content

Enable merge queue #10002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sarahchen6 wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Enable merge queue #10002

sarahchen6 wants to merge 9 commits into from

Conversation

@sarahchen6
Copy link
Contributor

@sarahchen6 sarahchen6 commented Nov 19, 2025 •
edited
Loading

What Does This Do

Enable a merge queue, and include the following configurations:

  • Merge using the squash method
  • Allow skipping merge queue checks for master, but require a reason for skipping these checks
    • This configuration is included as an extra precaution in case we need to override the merge queue, but it should be avoided because it defeats the purpose of a merge queue and would skip any checks specific to merge queues
  • Require the PR's commits to be signed
  • Require the PR to have all necessary reviews

We also allow merge-queue PR labels.

Motivation

By enabling a merge queue, not only can we ensure that PRs pass CI with the latest version of master, including all PRs merged before it, but also we can run certain checks (e.g. benchmarks) only when merging to master. Merge queues by default run with the "speculative" workflow type. More details here, but TLDR; each PR needs to pass with the latest version of master + any PRs that sit before it in the merge queue before being merged.

For now, we will start by enabling just the merge queue, keeping all PR checks as-is. If this is successful, we can start tailoring merge queue-specific checks.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@sarahchen6 sarahchen6 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Nov 19, 2025
@PerfectSlayer
Copy link
Contributor

PerfectSlayer commented Nov 20, 2025

Instead we can run benchmarks when manually triggered and merging to master through a merge queue. The check-big-regressions PR-gate would prevent large regressions from being merged to master, but it would be the responsibility of the developer to run benchmarks when relevant prior to putting their PR in the merge queue.

Would there be a way for benchmarks to excluded on purpose rather than opt-in? I guess big regression would catch most of the issues, but I would think that casual offenders introduce regression because their don't know about it, so they would not opt into benchmarks in the first place?
That's a discussion we can have with the guild :)

@sarahchen6
Copy link
Contributor Author

sarahchen6 commented Nov 20, 2025

Would there be a way for benchmarks to excluded on purpose rather than opt-in?

@PerfectSlayer Yes we can also do that! Perhaps we could run a longer, more stable benchmark in the merge queue and still have some benchmarks run on every push 🤔

That's a discussion we can have with the guild :)

Agreed! I'll wait for a Guild discussion before proceeding any further

@pr-commenter
Copy link

pr-commenter bot commented Jan 23, 2026 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master sarahchen6/enable-merge-queue
git_commit_date 1769528553 1769529980
git_commit_sha b11fcdf 6ec1542
release_version 1.59.0-SNAPSHOT~b11fcdfcfc 1.56.0-SNAPSHOT~6ec1542394
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1769531809 1769531809
ci_job_id 1380457671 1380457671
ci_pipeline_id 93072036 93072036
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-cdmqbbgd 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-cdmqbbgd 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~6ec1542394, baseline=1.59.0-SNAPSHOT~b11fcdfcfc

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062501
Total [baseline] (10.974 s) : 0, 10974143
Agent [candidate] (1.068 s) : 0, 1068003
Total [candidate] (11.008 s) : 0, 11008032
section appsec
Agent [baseline] (1.229 s) : 0, 1229081
Total [baseline] (10.88 s) : 0, 10879664
Agent [candidate] (1.231 s) : 0, 1231194
Total [candidate] (11.034 s) : 0, 11034073
section iast
Agent [baseline] (1.229 s) : 0, 1228702
Total [baseline] (11.177 s) : 0, 11177173
Agent [candidate] (1.228 s) : 0, 1228020
Total [candidate] (11.145 s) : 0, 11145106
section profiling
Agent [baseline] (1.186 s) : 0, 1186195
Total [baseline] (10.969 s) : 0, 10968820
Agent [candidate] (1.185 s) : 0, 1185131
Total [candidate] (10.944 s) : 0, 10944027
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent appsec 1.229 s 166.58 ms (15.7%)
Agent iast 1.229 s 166.201 ms (15.6%)
Agent profiling 1.186 s 123.694 ms (11.6%)
Total tracing 10.974 s -
Total appsec 10.88 s -94.478 ms (-0.9%)
Total iast 11.177 s 203.03 ms (1.9%)
Total profiling 10.969 s -5.323 ms (-0.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.068 s -
Agent appsec 1.231 s 163.191 ms (15.3%)
Agent iast 1.228 s 160.017 ms (15.0%)
Agent profiling 1.185 s 117.128 ms (11.0%)
Total tracing 11.008 s -
Total appsec 11.034 s 26.041 ms (0.2%)
Total iast 11.145 s 137.075 ms (1.2%)
Total profiling 10.944 s -64.005 ms (-0.6%) 
gantt
    title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~6ec1542394, baseline=1.59.0-SNAPSHOT~b11fcdfcfc

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (624.442 ms) : 0, 624442
BytebuddyAgent [candidate] (628.156 ms) : 0, 628156
AgentMeter [baseline] (28.731 ms) : 0, 28731
AgentMeter [candidate] (29.095 ms) : 0, 29095
GlobalTracer [baseline] (257.936 ms) : 0, 257936
GlobalTracer [candidate] (259.814 ms) : 0, 259814
AppSec [baseline] (33.147 ms) : 0, 33147
AppSec [candidate] (33.284 ms) : 0, 33284
Debugger [baseline] (63.22 ms) : 0, 63220
Debugger [candidate] (63.363 ms) : 0, 63363
Remote Config [baseline] (633.659 µs) : 0, 634
Remote Config [candidate] (626.621 µs) : 0, 627
Telemetry [baseline] (9.212 ms) : 0, 9212
Telemetry [candidate] (10.788 ms) : 0, 10788
Flare Poller [baseline] (8.47 ms) : 0, 8470
Flare Poller [candidate] (6.066 ms) : 0, 6066
section appsec
crashtracking [baseline] (1.168 ms) : 0, 1168
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (650.075 ms) : 0, 650075
BytebuddyAgent [candidate] (651.3 ms) : 0, 651300
AgentMeter [baseline] (11.832 ms) : 0, 11832
AgentMeter [candidate] (11.853 ms) : 0, 11853
GlobalTracer [baseline] (256.87 ms) : 0, 256870
GlobalTracer [candidate] (257.451 ms) : 0, 257451
AppSec [baseline] (167.355 ms) : 0, 167355
AppSec [candidate] (167.278 ms) : 0, 167278
Debugger [baseline] (67.376 ms) : 0, 67376
Debugger [candidate] (67.665 ms) : 0, 67665
Remote Config [baseline] (685.816 µs) : 0, 686
Remote Config [candidate] (678.635 µs) : 0, 679
Telemetry [baseline] (9.294 ms) : 0, 9294
Telemetry [candidate] (9.274 ms) : 0, 9274
Flare Poller [baseline] (3.691 ms) : 0, 3691
Flare Poller [candidate] (3.692 ms) : 0, 3692
IAST [baseline] (25.424 ms) : 0, 25424
IAST [candidate] (25.444 ms) : 0, 25444
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.171 ms) : 0, 1171
BytebuddyAgent [baseline] (791.384 ms) : 0, 791384
BytebuddyAgent [candidate] (791.073 ms) : 0, 791073
AgentMeter [baseline] (11.169 ms) : 0, 11169
AgentMeter [candidate] (11.167 ms) : 0, 11167
GlobalTracer [baseline] (248.339 ms) : 0, 248339
GlobalTracer [candidate] (248.402 ms) : 0, 248402
AppSec [baseline] (33.285 ms) : 0, 33285
AppSec [candidate] (33.034 ms) : 0, 33034
Debugger [baseline] (68.134 ms) : 0, 68134
Debugger [candidate] (68.065 ms) : 0, 68065
Remote Config [baseline] (544.691 µs) : 0, 545
Remote Config [candidate] (542.903 µs) : 0, 543
Telemetry [baseline] (8.741 ms) : 0, 8741
Telemetry [candidate] (8.669 ms) : 0, 8669
Flare Poller [baseline] (3.509 ms) : 0, 3509
Flare Poller [candidate] (3.511 ms) : 0, 3511
IAST [baseline] (26.882 ms) : 0, 26882
IAST [candidate] (26.981 ms) : 0, 26981
section profiling
ProfilingAgent [baseline] (100.444 ms) : 0, 100444
ProfilingAgent [candidate] (99.696 ms) : 0, 99696
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (676.076 ms) : 0, 676076
BytebuddyAgent [candidate] (676.399 ms) : 0, 676399
AgentMeter [baseline] (8.634 ms) : 0, 8634
AgentMeter [candidate] (8.686 ms) : 0, 8686
GlobalTracer [baseline] (216.134 ms) : 0, 216134
GlobalTracer [candidate] (216.221 ms) : 0, 216221
AppSec [baseline] (32.431 ms) : 0, 32431
AppSec [candidate] (32.167 ms) : 0, 32167
Debugger [baseline] (68.245 ms) : 0, 68245
Debugger [candidate] (67.656 ms) : 0, 67656
Remote Config [baseline] (609.239 µs) : 0, 609
Remote Config [candidate] (589.334 µs) : 0, 589
Telemetry [baseline] (8.766 ms) : 0, 8766
Telemetry [candidate] (8.789 ms) : 0, 8789
Flare Poller [baseline] (3.758 ms) : 0, 3758
Flare Poller [candidate] (3.767 ms) : 0, 3767
Profiling [baseline] (101.032 ms) : 0, 101032
Profiling [candidate] (100.272 ms) : 0, 100272
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~6ec1542394, baseline=1.59.0-SNAPSHOT~b11fcdfcfc

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056874
Total [baseline] (8.704 s) : 0, 8704314
Agent [candidate] (1.057 s) : 0, 1057339
Total [candidate] (8.708 s) : 0, 8707761
section iast
Agent [baseline] (1.232 s) : 0, 1232354
Total [baseline] (9.412 s) : 0, 9411587
Agent [candidate] (1.227 s) : 0, 1227160
Total [candidate] (9.411 s) : 0, 9410517
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.232 s 175.48 ms (16.6%)
Total tracing 8.704 s -
Total iast 9.412 s 707.272 ms (8.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.227 s 169.822 ms (16.1%)
Total tracing 8.708 s -
Total iast 9.411 s 702.756 ms (8.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~6ec1542394, baseline=1.59.0-SNAPSHOT~b11fcdfcfc

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (622.094 ms) : 0, 622094
BytebuddyAgent [candidate] (622.73 ms) : 0, 622730
AgentMeter [baseline] (28.774 ms) : 0, 28774
AgentMeter [candidate] (28.814 ms) : 0, 28814
GlobalTracer [baseline] (257.062 ms) : 0, 257062
GlobalTracer [candidate] (257.248 ms) : 0, 257248
AppSec [baseline] (32.797 ms) : 0, 32797
AppSec [candidate] (32.768 ms) : 0, 32768
Debugger [baseline] (60.587 ms) : 0, 60587
Debugger [candidate] (60.062 ms) : 0, 60062
Remote Config [baseline] (637.273 µs) : 0, 637
Remote Config [candidate] (622.861 µs) : 0, 623
Telemetry [baseline] (9.868 ms) : 0, 9868
Telemetry [candidate] (10.656 ms) : 0, 10656
Flare Poller [baseline] (8.438 ms) : 0, 8438
Flare Poller [candidate] (7.676 ms) : 0, 7676
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (795.327 ms) : 0, 795327
BytebuddyAgent [candidate] (791.972 ms) : 0, 791972
AgentMeter [baseline] (11.372 ms) : 0, 11372
AgentMeter [candidate] (11.173 ms) : 0, 11173
GlobalTracer [baseline] (248.971 ms) : 0, 248971
GlobalTracer [candidate] (248.222 ms) : 0, 248222
AppSec [baseline] (34.105 ms) : 0, 34105
AppSec [candidate] (32.12 ms) : 0, 32120
Debugger [baseline] (66.172 ms) : 0, 66172
Debugger [candidate] (67.559 ms) : 0, 67559
Remote Config [baseline] (544.68 µs) : 0, 545
Remote Config [candidate] (552.683 µs) : 0, 553
Telemetry [baseline] (8.57 ms) : 0, 8570
Telemetry [candidate] (8.554 ms) : 0, 8554
Flare Poller [baseline] (3.489 ms) : 0, 3489
Flare Poller [candidate] (3.49 ms) : 0, 3490
IAST [baseline] (27.054 ms) : 0, 27054
IAST [candidate] (26.841 ms) : 0, 26841
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master sarahchen6/enable-merge-queue
git_commit_date 1769528553 1769529980
git_commit_sha b11fcdf 6ec1542
release_version 1.59.0-SNAPSHOT~b11fcdfcfc 1.56.0-SNAPSHOT~6ec1542394
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1769532197 1769532197
ci_job_id 1380457676 1380457676
ci_pipeline_id 93072036 93072036
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-kweuakdy 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-kweuakdy 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 2 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:petclinic:appsec:high_load worse
[+0.944ms; +2.139ms] or [+5.232%; +11.856%]		 worse
[+0.791ms; +2.391ms] or [+2.655%; +8.028%]		 unstable
[-42.743op/s; +5.118op/s] or [-16.876%; +2.021%]		 19.579ms 31.373ms 234.469op/s 18.038ms 29.783ms 253.281op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~6ec1542394, baseline=1.59.0-SNAPSHOT~b11fcdfcfc
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.789 ms) : 18599, 18979
.   : milestone, 18789,
appsec (18.426 ms) : 18238, 18615
.   : milestone, 18426,
code_origins (17.522 ms) : 17348, 17696
.   : milestone, 17522,
iast (17.858 ms) : 17679, 18037
.   : milestone, 17858,
profiling (19.988 ms) : 19782, 20195
.   : milestone, 19988,
tracing (18.478 ms) : 18293, 18663
.   : milestone, 18478,
section candidate
no_agent (18.227 ms) : 18040, 18415
.   : milestone, 18227,
appsec (19.911 ms) : 19707, 20115
.   : milestone, 19911,
code_origins (17.814 ms) : 17634, 17994
.   : milestone, 17814,
iast (17.663 ms) : 17489, 17838
.   : milestone, 17663,
profiling (19.197 ms) : 19002, 19392
.   : milestone, 19197,
tracing (17.946 ms) : 17765, 18127
.   : milestone, 17946,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.789 ms [18.599 ms, 18.979 ms] -
appsec 18.426 ms [18.238 ms, 18.615 ms] -362.159 µs (-1.9%)
code_origins 17.522 ms [17.348 ms, 17.696 ms] -1.267 ms (-6.7%)
iast 17.858 ms [17.679 ms, 18.037 ms] -930.64 µs (-5.0%)
profiling 19.988 ms [19.782 ms, 20.195 ms] 1.2 ms (6.4%)
tracing 18.478 ms [18.293 ms, 18.663 ms] -310.169 µs (-1.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.227 ms [18.04 ms, 18.415 ms] -
appsec 19.911 ms [19.707 ms, 20.115 ms] 1.684 ms (9.2%)
code_origins 17.814 ms [17.634 ms, 17.994 ms] -413.336 µs (-2.3%)
iast 17.663 ms [17.489 ms, 17.838 ms] -564.155 µs (-3.1%)
profiling 19.197 ms [19.002 ms, 19.392 ms] 969.586 µs (5.3%)
tracing 17.946 ms [17.765 ms, 18.127 ms] -281.516 µs (-1.5%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~6ec1542394, baseline=1.59.0-SNAPSHOT~b11fcdfcfc
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.283 ms) : 1268, 1297
.   : milestone, 1283,
iast (3.217 ms) : 3168, 3265
.   : milestone, 3217,
iast_FULL (5.658 ms) : 5603, 5714
.   : milestone, 5658,
iast_GLOBAL (3.446 ms) : 3396, 3496
.   : milestone, 3446,
profiling (2.081 ms) : 2062, 2100
.   : milestone, 2081,
tracing (1.81 ms) : 1794, 1825
.   : milestone, 1810,
section candidate
no_agent (1.184 ms) : 1173, 1196
.   : milestone, 1184,
iast (3.221 ms) : 3176, 3266
.   : milestone, 3221,
iast_FULL (5.678 ms) : 5622, 5734
.   : milestone, 5678,
iast_GLOBAL (3.543 ms) : 3491, 3595
.   : milestone, 3543,
profiling (1.973 ms) : 1956, 1990
.   : milestone, 1973,
tracing (1.847 ms) : 1831, 1863
.   : milestone, 1847,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.283 ms [1.268 ms, 1.297 ms] -
iast 3.217 ms [3.168 ms, 3.265 ms] 1.934 ms (150.8%)
iast_FULL 5.658 ms [5.603 ms, 5.714 ms] 4.376 ms (341.2%)
iast_GLOBAL 3.446 ms [3.396 ms, 3.496 ms] 2.163 ms (168.7%)
profiling 2.081 ms [2.062 ms, 2.1 ms] 798.519 µs (62.3%)
tracing 1.81 ms [1.794 ms, 1.825 ms] 527.028 µs (41.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.184 ms [1.173 ms, 1.196 ms] -
iast 3.221 ms [3.176 ms, 3.266 ms] 2.037 ms (172.0%)
iast_FULL 5.678 ms [5.622 ms, 5.734 ms] 4.494 ms (379.4%)
iast_GLOBAL 3.543 ms [3.491 ms, 3.595 ms] 2.359 ms (199.1%)
profiling 1.973 ms [1.956 ms, 1.99 ms] 788.442 µs (66.6%)
tracing 1.847 ms [1.831 ms, 1.863 ms] 662.649 µs (55.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master sarahchen6/enable-merge-queue
git_commit_date 1769528553 1769529980
git_commit_sha b11fcdf 6ec1542
release_version 1.59.0-SNAPSHOT~b11fcdfcfc 1.56.0-SNAPSHOT~6ec1542394
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1769532145 1769532145
ci_job_id 1380457680 1380457680
ci_pipeline_id 93072036 93072036
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-8ijadki5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-8ijadki5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~6ec1542394, baseline=1.59.0-SNAPSHOT~b11fcdfcfc
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.416 s) : 15416000, 15416000
.   : milestone, 15416000,
appsec (14.845 s) : 14845000, 14845000
.   : milestone, 14845000,
iast (18.153 s) : 18153000, 18153000
.   : milestone, 18153000,
iast_GLOBAL (17.894 s) : 17894000, 17894000
.   : milestone, 17894000,
profiling (15.33 s) : 15330000, 15330000
.   : milestone, 15330000,
tracing (14.759 s) : 14759000, 14759000
.   : milestone, 14759000,
section candidate
no_agent (14.973 s) : 14973000, 14973000
.   : milestone, 14973000,
appsec (14.933 s) : 14933000, 14933000
.   : milestone, 14933000,
iast (17.791 s) : 17791000, 17791000
.   : milestone, 17791000,
iast_GLOBAL (17.56 s) : 17560000, 17560000
.   : milestone, 17560000,
profiling (14.725 s) : 14725000, 14725000
.   : milestone, 14725000,
tracing (14.6 s) : 14600000, 14600000
.   : milestone, 14600000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.416 s [15.416 s, 15.416 s] -
appsec 14.845 s [14.845 s, 14.845 s] -571.0 ms (-3.7%)
iast 18.153 s [18.153 s, 18.153 s] 2.737 s (17.8%)
iast_GLOBAL 17.894 s [17.894 s, 17.894 s] 2.478 s (16.1%)
profiling 15.33 s [15.33 s, 15.33 s] -86.0 ms (-0.6%)
tracing 14.759 s [14.759 s, 14.759 s] -657.0 ms (-4.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.973 s [14.973 s, 14.973 s] -
appsec 14.933 s [14.933 s, 14.933 s] -40.0 ms (-0.3%)
iast 17.791 s [17.791 s, 17.791 s] 2.818 s (18.8%)
iast_GLOBAL 17.56 s [17.56 s, 17.56 s] 2.587 s (17.3%)
profiling 14.725 s [14.725 s, 14.725 s] -248.0 ms (-1.7%)
tracing 14.6 s [14.6 s, 14.6 s] -373.0 ms (-2.5%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~6ec1542394, baseline=1.59.0-SNAPSHOT~b11fcdfcfc
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
.   : milestone, 1477,
appsec (3.774 ms) : 3552, 3996
.   : milestone, 3774,
iast (2.274 ms) : 2204, 2344
.   : milestone, 2274,
iast_GLOBAL (2.311 ms) : 2241, 2380
.   : milestone, 2311,
profiling (2.131 ms) : 2074, 2189
.   : milestone, 2131,
tracing (2.062 ms) : 2009, 2116
.   : milestone, 2062,
section candidate
no_agent (1.479 ms) : 1467, 1490
.   : milestone, 1479,
appsec (3.776 ms) : 3553, 3999
.   : milestone, 3776,
iast (2.267 ms) : 2197, 2336
.   : milestone, 2267,
iast_GLOBAL (2.305 ms) : 2235, 2375
.   : milestone, 2305,
profiling (2.107 ms) : 2050, 2164
.   : milestone, 2107,
tracing (2.074 ms) : 2020, 2128
.   : milestone, 2074,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.466 ms, 1.489 ms] -
appsec 3.774 ms [3.552 ms, 3.996 ms] 2.297 ms (155.5%)
iast 2.274 ms [2.204 ms, 2.344 ms] 797.154 µs (54.0%)
iast_GLOBAL 2.311 ms [2.241 ms, 2.38 ms] 833.657 µs (56.4%)
profiling 2.131 ms [2.074 ms, 2.189 ms] 654.236 µs (44.3%)
tracing 2.062 ms [2.009 ms, 2.116 ms] 585.236 µs (39.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.479 ms [1.467 ms, 1.49 ms] -
appsec 3.776 ms [3.553 ms, 3.999 ms] 2.297 ms (155.3%)
iast 2.267 ms [2.197 ms, 2.336 ms] 787.789 µs (53.3%)
iast_GLOBAL 2.305 ms [2.235 ms, 2.375 ms] 825.733 µs (55.8%)
profiling 2.107 ms [2.05 ms, 2.164 ms] 627.927 µs (42.5%)
tracing 2.074 ms [2.02 ms, 2.128 ms] 594.997 µs (40.2%)

@bric3
Copy link
Contributor

bric3 commented Jan 23, 2026 •
edited
Loading

@sarahchen6 Do we need doggo in the browser ? I disabled it, just too many things not working ?

@sarahchen6
Copy link
Contributor Author

sarahchen6 commented Jan 23, 2026 •
edited
Loading

Do we need doggo in the browser ?

@bric3 No doggo isn't necessary - you can interact with the merge queue through comments (ref) as well

@sarahchen6 sarahchen6 marked this pull request as ready for review January 23, 2026 18:19
@sarahchen6 sarahchen6 requested a review from a team as a code owner January 23, 2026 18:19
PerfectSlayer
PerfectSlayer reviewed Jan 26, 2026
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Require the PR to have at least one label
What label exactly?

If merge-queue: labels are required, you might need to update the valid categories here: https://github.com/DataDog/dd-trace-java/blob/master/.github/workflows/check-pull-request-labels.yaml#L28

@sarahchen6
Copy link
Contributor Author

sarahchen6 commented Jan 26, 2026

If merge-queue: labels are required, you might need to update the valid categories here:

@PerfectSlayer Ah good point, will do. We can also optionally skip the merge queue labels (ref), but I'll add them to the allow list for now and remove this redundant label requirement.

@sarahchen6 sarahchen6 requested a review from a team as a code owner January 26, 2026 14:41
bric3
bric3 approved these changes Jan 27, 2026
View reviewed changes
Copy link
Contributor

@bric3 bric3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but got a couple of questions !

repository.datadog.yaml
Comment on lines +8 to +9
allow_skip_checks: true
require_reason_for_skip_checks: true
Copy link
Contributor

@bric3 bric3 Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: allow skip checks ?

Copy link
Contributor Author

@sarahchen6 sarahchen6 Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - Especially while we experiment with merge queues, I think it'd be safe to include a way to override the queue process.

sarahchen6 and others added 2 commits January 27, 2026 10:06
@sarahchen6 @bric3
Update repository.datadog.yaml
eb4b43a 
Co-authored-by: Brice Dutheil <brice.dutheil@gmail.com>
@sarahchen6 @bric3
Update repository.datadog.yaml
6ec1542 
Co-authored-by: Brice Dutheil <brice.dutheil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer left review comments

@bric3 bric3 bric3 approved these changes

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD AlexeyKuznetsov-DD approved these changes

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sarahchen6 @PerfectSlayer @bric3 @AlexeyKuznetsov-DD