-
Notifications
You must be signed in to change notification settings - Fork 129
Add spec.feature.autodiscovery.extra_ignore_autoconfig in DatadogAgent #2299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bits AI Dev Agent Status: ✅ Done [Fix CI Errors] Status History (20 entries)You can ask for changes by mentioning @DataDog in a comment. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2299 +/- ##
==========================================
+ Coverage 37.32% 37.35% +0.03%
==========================================
Files 290 291 +1
Lines 24720 24757 +37
==========================================
+ Hits 9226 9249 +23
- Misses 14781 14790 +9
- Partials 713 718 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
e0866f5 to
8d2f73c
Compare
fanny-jiang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just needs one change to register the new feature
2752b78 to
ae9658a
Compare
CONTP-1086: move autoconfig ignore to features
ae9658a to
9fdebd8
Compare
You can ask for changes by mentioning @DataDog in a comment.
Feedback (especially what can be better) welcome in #code-gen-feedback!
What does this PR do?
Implements CONTP-1086 by adding a
feature.autodiscovery.extraIgnoreAutoConfigsetting to the DatadogAgent CRD. This allows users to configure integrations to ignore from autodiscovery without overriding the operator's default ignored list. Includes generated deepcopy and OpenAPI schema definitions for the newAutodiscoveryConfigstruct, feature implementation, and comprehensive unit tests. Additionally marks the Agent component as required in the single-container strategy to ensure proper container selection. Fixes indentation in the autodiscovery feature comment for code consistency.Motivation
Users previously had to override the entire
DD_IGNORE_AUTOCONFenvironment variable to add custom integrations to the ignore list, which removed the operator's default ignored integrations (e.g., "kubernetes_state"). This caused support issues and inaccurate metrics. The new setting allows appending to the default list instead of replacing it. Marking Agent as required ensures the single-container strategy correctly switches to the unprivileged container when this feature is utilized. Fixing the indentation ensures code quality and maintainability.Additional Notes
AutodiscoveryConfigstruct added toDatadogFeatureswithExtraIgnoreAutoConfigfieldAutodiscoveryConfigto support proper object cloningAppendToValueEnvVarMergeFunctionto merge values with existing environment variablesDD_IGNORE_AUTOCONFvalues across all container typesMinimum Agent Versions
Describe your test plan
DD_IGNORE_AUTOCONFvaluesChecklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel