build layer using dd-trace branch#146
Merged
Merged
Conversation
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
purple4reina
reviewed
May 7, 2026
| cd /tmp/dd-trace-rb; \ | ||
| git checkout "$git_ref"; \ | ||
| gem build datadog.gemspec; \ | ||
| gem install ./datadog-*.gem --install-dir "/opt/ruby/gems/$runtime"; \ |
Contributor
There was a problem hiding this comment.
Is there not a way to install using the remote git ref? So you don't have to clone the repo? Cloning a repo in gitlab requires a whole set of permissions that would need to be updated to our gitlab projects.
Contributor
Author
There was a problem hiding this comment.
I was able to clone it in this gitlab job
purple4reina
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
enables building layers using a specific dd-trace-rb ref rather than always using the recent release
Motivation
Testing Guidelines
Additional Notes
Types of changes
Check all that apply