Skip to content

chore: make clippy+fmt commit hook cd relative to project root#1252

Open
lucaspimentel wants to merge 1 commit into
mainfrom
lpimentel/fix-clippy-hook-cwd
Open

chore: make clippy+fmt commit hook cd relative to project root#1252
lucaspimentel wants to merge 1 commit into
mainfrom
lpimentel/fix-clippy-hook-cwd

Conversation

@lucaspimentel

@lucaspimentel lucaspimentel commented Jun 11, 2026

Copy link
Copy Markdown
Member

The clippy + fmt pre-commit hook in .claude/settings.json used a bare cd bottlecap, which only resolved from the repo root. Switched to cd "$CLAUDE_PROJECT_DIR/bottlecap" so it works from subdirectories too.

@lucaspimentel lucaspimentel changed the title chore: make clippy+fmt commit hook cd relative to project root chore: make clippy+fmt commit hook cd relative to project root Jun 11, 2026
@lucaspimentel lucaspimentel marked this pull request as ready for review June 11, 2026 20:08
@lucaspimentel lucaspimentel requested a review from a team as a code owner June 11, 2026 20:08
@lucaspimentel lucaspimentel requested review from Copilot and shreyamalpani and removed request for Copilot June 11, 2026 20:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Claude pre-commit hook configuration so cargo clippy and cargo fmt run from the correct workspace directory regardless of the current working directory when the hook executes.

Changes:

  • Make the hook cd into bottlecap using $CLAUDE_PROJECT_DIR (project-root-relative) instead of a bare relative path.

@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Jun 11, 2026

Copy link
Copy Markdown

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

DataDog/datadog-lambda-extension | e2e-test-status (amd64, fips)   View in Datadog   GitLab

DataDog/datadog-lambda-extension | e2e-test-status (amd64)   View in Datadog   GitLab

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0dc2b65 | Docs | Datadog PR Page | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants