fix(appsec): remove http method from 'http.route' span tag#1247
Open
florentinl wants to merge 1 commit into
Open
fix(appsec): remove http method from 'http.route' span tag#1247florentinl wants to merge 1 commit into
florentinl wants to merge 1 commit into
Conversation
|
florentinl
requested review from
RomainMuller,
Copilot and
duncanista
and removed request for
Copilot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Currently the appsec span processor sets the
http.routetag to{method} {route}instead of just{route}(ex:GET /echoinstead of/echo). This does not match the APM spec as well as the tag extracted by the lifecycle processor on the http triggers.Testing
updated existing test
e2e tests are failing but I think it is unrelated