Skip to content

fix: remove noisy per-PID trace logs from fd usage collection #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
purple4reina wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove noisy per-PID trace logs from fd usage collection #1246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions bottlecap/src/proc/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ use constants::{
PROC_NET_DEV_PATH, PROC_PATH, PROC_STAT_PATH, PROC_UPTIME_PATH,
};
use regex::Regex;
use tracing::{debug, trace};
use tracing::debug;

#[must_use]
pub fn get_pid_list() -> Vec<i64> {
Expand Down Expand Up @@ -258,14 +258,9 @@ fn get_fd_use_data_from_path(path: &str, pids: &[i64]) -> f64 {
for &pid in pids {
let fd_path = format!("{path}/{pid}/fd");
let Ok(files) = fs::read_dir(&fd_path) else {
trace!(
"File descriptor use data not found in path {} with pid {}",
fd_path, pid
);
continue;
};
let count = files.count();
fd_use += count;
fd_use += files.count();
}

fd_use as f64
Expand Down
Loading