chore(deps): bump libdatadog to 48da0d8 for client-computed header fix#1244
Merged
lucaspimentel merged 3 commits intoJun 8, 2026
Merged
Conversation
Bump all libdd-* dependencies from db05e1f to 48da0d8 to pick up libdatadog PR #2071, which fixes how `From<&HeaderMap> for TracerHeaderTags` parses the `datadog-client-computed-stats` and `datadog-client-computed-top-level` headers so the behavior matches the Go trace-agent. Bottlecap consumes this path in traces/trace_agent.rs via `(&parts.headers).into()`. Adapt to breaking API changes between the two revisions: - libdd_capabilities `HttpClientTrait` was renamed to `HttpClientCapability`. - `SendData::send` now requires `C: HttpClientCapability + SleepCapability`, so implement `SleepCapability` for `HttpClient` (backed by tokio::time::sleep, mirroring libdatadog's NativeSleepCapability).
|
lucaspimentel
changed the title
libdatadog to 48da0d8 for client-computed header fix
…the libdatadog bump Adds a #[cfg(test)] mod tests block at the (&headers).into() boundary that handle_traces uses, giving the db05e1f -> 48da0d8 bump its missing behavioral coverage for libdatadog#2071. Assertions are Go-agent-aligned (isHeaderTrue/ ParseBool): truthy values -> true, absent/empty -> false, falsey literals (false/0/f/F/FALSE/False) -> false, and client_computed_top_level no longer set by presence alone. These would fail on the pre-bump rev.
lucaspimentel
added a commit
that referenced
this pull request
Jun 3, 2026
…datadog bump PR The Tier 0 tests assert libdatadog parsing behavior (not the _dd.compute_stats feature), and libdatadog#2071 changes that behavior via the db05e1f -> 48da0d8 bump in PR #1244. Move them there so the bump carries its own behavioral coverage and the assertions don't need to assert opposite things on two branches. Feature branch keeps Tiers 1-3; rebase onto #1244 after it merges.
lucaspimentel
added a commit
that referenced
this pull request
Jun 3, 2026
…datadog bump PR The Tier 0 tests assert libdatadog parsing behavior (not the _dd.compute_stats feature), and libdatadog#2071 changes that behavior via the db05e1f -> 48da0d8 bump in PR #1244. Move them there so the bump carries its own behavioral coverage and the assertions don't need to assert opposite things on two branches. Feature branch keeps Tiers 1-3; rebase onto #1244 after it merges.
Describe the exact false-set the parser recognizes and note that non-ParseBool values like "yes" resolve to true, matching what the truthy-values test asserts. 🤖 Co-Authored-By: Claude Code <noreply@anthropic.com>
2 tasks
duncanista
reviewed
Jun 4, 2026
duncanista
approved these changes
Jun 8, 2026
lucaspimentel
deleted the
lpimentel/bump-libdatadog-client-computed-headers
branch
duncanista
added a commit
to DataDog/serverless-components
that referenced
this pull request
Jun 10, 2026
Aligns libdatadog rev across all crates with the datadog-lambda-extension bottlecap binary, which was bumped to this rev in DataDog/datadog-lambda-extension#1244 for the client-computed header fix. Required so bottlecap can consume datadog-agent-config without ending up with two incompatible copies of libdd-trace-obfuscation::ReplaceRule in its dependency graph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Bump all
libdd-*dependencies fromdb05e1fto48da0d8to pick up libdatadog PR #2071, which fixes how thedatadog-client-computed-statsanddatadog-client-computed-top-levelheaders are parsed so the behavior matches the Go trace-agent.Bottlecap consumes this exact path in
bottlecap/src/traces/trace_agent.rsvia(&parts.headers).into(), so it directly benefits from the fix.Adapting to breaking API changes between the two revisions
HttpClientTraitwas renamed toHttpClientCapabilitySendData::sendnow requiresC: HttpClientCapability + SleepCapability, so implementedSleepCapabilityforHttpClientTesting
Added Tier 0 coverage in
trace_agent.rspinning the new header-parsing behavior at the(&headers).into()boundaryhandle_tracesuses:true,yes,t,1-> flag setfalse,0,f,F,FALSE,False-> flag clearclient_computed_top_levelno longer set by presence alone (pre-bump regression)These test would fail on the pre-bump rev (
db05e1f), so they lock in the fix.APMSVLS-487