Skip to content

fix: lowercase DD_SERVICE on processors #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duncanista merged 4 commits into from
Feb 4, 2026
Merged

fix: lowercase DD_SERVICE on processors #1013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8b767e
ensure we lowercase service
duncanista Feb 2, 2026
1288941
fmt
duncanista Feb 2, 2026
bef0662
Merge branch 'main' into jordan.gonzalez/config/fix-service-to-lowercase
duncanista Feb 3, 2026
6066f5f
Merge branch 'main' into jordan.gonzalez/config/fix-service-to-lowercase
duncanista Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bottlecap/src/lifecycle/invocation/processor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ impl Processor {
&config.service.clone().unwrap_or(resource.clone()),
"aws.lambda",
config.trace_aws_service_representation_enabled,
);
)
.to_lowercase();

let enhanced_metrics = EnhancedMetrics::new(metrics_aggregator, Arc::clone(&config));
enhanced_metrics.start_usage_metrics_task(); // starts the long-running task that monitors usage metrics (fd_use, threads_use, tmp_used)
Expand Down
6 changes: 5 additions & 1 deletion bottlecap/src/logs/lambda/processor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,11 @@ impl LambdaProcessor {
event_bus: Sender<Event>,
is_managed_instance_mode: bool,
) -> Self {
let service = datadog_config.service.clone().unwrap_or_default();
let service = datadog_config
.service
.clone()
.unwrap_or_default()
.to_lowercase();
let tags = tags_provider.get_tags_string();
let function_arn = tags_provider.get_canonical_id().unwrap_or_default();

Expand Down
2 changes: 1 addition & 1 deletion bottlecap/src/tags/lambda/tags.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ fn tags_from_env(
tags_map.insert(ENV_KEY.to_string(), env.to_string());
}
if let Some(service) = &config.service {
tags_map.insert(SERVICE_KEY.to_string(), service.to_string());
tags_map.insert(SERVICE_KEY.to_string(), service.to_lowercase());
}
if let Ok(init_type) = std::env::var(INIT_TYPE) {
tags_map.insert(INIT_TYPE_KEY.to_string(), init_type);
Expand Down
7 changes: 6 additions & 1 deletion bottlecap/src/traces/stats_concentrator_service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,12 @@ impl StatsConcentratorService {
sequence: 0,
// Not supported yet
agent_aggregation: String::new(),
service: self.config.service.clone().unwrap_or_default(),
service: self
.config
.service
.clone()
.unwrap_or_default()
.to_lowercase(),
container_id: self.tracer_metadata.container_id.clone(),
// Not supported yet
tags: vec![],
Expand Down
Loading