avoid setting cold start on managed instances mode #1008
+29
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We need to update integration tests for this. |
| expect(awsLambdaSpan?.attributes.custom.cold_start).toBe('false'); | ||
| // Skip cold_start tag check for Node and Python since their tracer libraries | ||
| // (dd-trace-js, dd-trace-py) set the cold_start attribute independently. | ||
| // Only verify for Java and dotnet where bottlecap controls the span. |
Contributor
There was a problem hiding this comment.
What is our plan to fix this for Node and Python runtimes?
Contributor
Author
There was a problem hiding this comment.
Needs to be done separately until fixed, there's no way of checking this until its fixed there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Skips setting cold start on Managed Instances
Why?
SVLS-8232