Support x-keep-typed-in-additional-properties in Rust model generator#1730
Open
charlie-zhang109 wants to merge 3 commits into
Open
Support x-keep-typed-in-additional-properties in Rust model generator#1730charlie-zhang109 wants to merge 3 commits into
charlie-zhang109 wants to merge 3 commits into
Conversation
When a schema sets `x-keep-typed-in-additional-properties: true`, pre-insert every key into `additional_properties` before the match dispatch so typed and untyped fields are both accessible from a single map. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…rde_json::Value Add inline comment explaining that deserializing into serde_json::Value always succeeds, so the Ok branch always fires. The guard future-proofs against typed additionalProperties schemas where the conversion could fail. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…comment "future-proofs" implied graceful handling; the comment now accurately notes that a type mismatch silently drops the entry, same as the catch-all arm. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a schema sets
x-keep-typed-in-additional-properties: true(introduced in DataDog/datadog-api-spec#5941), the Rust model generator pre-inserts every JSON key intoadditional_propertiesbefore the match dispatch indeserialize. Previously, only the&_catch-all arm (unknown keys) populated the map.The first consumer is
UsageSummaryDate,UsageSummaryDateOrg, andUsageSummaryResponse. After this change, every field on those models is accessible fromadditional_propertiesregardless of when it was added to the spec.Typed field accessors are unchanged — this is additive only.
Companion PRs:
Review checklist
This PR includes all newly recorded cassettes for any modified tests.
This PR does not rely on API client schema changes.
Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.