Skip to content

Conversation

@MintsInc
Copy link
Member

@MintsInc MintsInc commented Jan 28, 2026

Context

BDD test undo operations fail when path parameters are needed from fixture-based resources (e.g., "there is a valid X in the system" steps). The build_given function creates fixtures but doesn't store path parameters needed for cleanup.

Changes

  • Enhanced path parameter lookup in undo operations to try snake_case variant (to_parameter)
  • Added path parameter storage in build_given for fixture creation
    • Identifies path parameters as required positional params (excluding "body")
    • Stores with all naming variants: original, snake_case, and symbol
  • Enhanced "request contains" steps to store snake_case variant

Tests

Run BDD tests using fixtures with path parameters (on top of the changes generated by https://github.com/DataDog/datadog-api-spec/pull/4875). Verify undo operations find and use path parameters correctly.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MintsInc MintsInc marked this pull request as ready for review January 28, 2026 09:52
@MintsInc MintsInc requested review from a team as code owners January 28, 2026 09:52
@MintsInc MintsInc merged commit 31b6c08 into master Jan 28, 2026
19 of 20 checks passed
@MintsInc MintsInc deleted the ulysse.mavrocordatos/fix-path-parameter-in-undo branch January 28, 2026 12:29
github-actions bot pushed a commit to ConnectionMaster/datadog-api-client-ruby that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants