feat: QueryAsync with CommandDefinition and Type[] multi-map#2209
Open
leno23 wants to merge 1 commit into
Open
feat: QueryAsync with CommandDefinition and Type[] multi-map#2209leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Expose cancellable multi-map queries with more than seven types by forwarding to the existing MultiMapAsync implementation.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
QueryAsync<TReturn>(IDbConnection, CommandDefinition, Type[], Func<object[], TReturn>, splitOn)so multi-map queries with more than seven types can use cancellation and otherCommandDefinitionoptions.The private
MultiMapAsyncimplementation already supported this path; the existingstring sqloverload constructed aCommandDefinitionwithout exposing cancellation.Test plan
TestMultiMapArbitraryMapsCommandDefinitionAsync(10-type map viaCommandDefinition+CancellationToken)Fixes #2193
Made with Cursor