fix: pass IParameterCallbacks to GridReader for QueryMultiple#2205
Open
leno23 wants to merge 1 commit into
Open
fix: pass IParameterCallbacks to GridReader for QueryMultiple#2205leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Use IParameterCallbacks when constructing GridReader so custom parameter implementations receive OnCompleted callbacks, not only DynamicParameters. Fixes DapperLib#2179
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
command.ParameterstoIParameterCallbacks(notDynamicParameters) when creatingGridReaderin sync and asyncQueryMultiplepaths.Motivation
Fixes #2179 — custom
IParameterCallbacksimplementations were ignored because onlyDynamicParameterswas passed through, even thoughGridReaderalready acceptsIParameterCallbacks.Test plan
QueryMultiple/ async grid reader tests intests/Dapper.TestsMade with Cursor