Remove rustc-serialize usage #415
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that rustc-serialize has been marked as deprecated, it seems prudent to drop it's usage and replace the functionality with other crates. Within this project, it was only used for base64 and hex encoding. Also, the hex encoding is for testing purposes. Other crates exist for those purposes, making this change quite easy.
dtolnay
approved these changes
May 22, 2017
|
We would love to pick this up in hibari/hibari-brick-rs#8. @DaGenix could you take a look? |
|
Can we get this merged? |
|
LGTM |
|
vote for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that rustc-serialize has been marked as deprecated, it seems prudent
to drop it's usage and replace the functionality with other crates.
Within this project, it was only used for base64 and hex encoding. Also,
the hex encoding is for testing purposes. Other crates exist for those
purposes(base64 and hex), making this change quite easy.