Skip to content

Allow a type-bind to a custom field#5801

Draft
jlipka wants to merge 2 commits into
DSpace:mainfrom
jlipka:feat/type-bind-to-custom-field
Draft

Allow a type-bind to a custom field#5801
jlipka wants to merge 2 commits into
DSpace:mainfrom
jlipka:feat/type-bind-to-custom-field

Conversation

@jlipka
Copy link
Copy Markdown
Contributor

@jlipka jlipka commented Jun 5, 2026

References

Description

These changes (together with DSpace/DSpace#12631 ) allow you to create a type-bind inside a submission (workspace / workflow) to other fields than "dc.type".

Instructions for Reviewers

Take a look at DSpace/DSpace#12631 for an example configuration.

This pull request has been created as a draft. This version works well for us, but it may not be suitable for all cases or needs. Feel free to test and comment. As soon as someone gives an opinion i could remove the draft mode.

List of changes in this PR:

  • The subscription to the related input fields is handled slightly differently to before. Instead of listening to the valueChanges of the related model, I changed the code to listen to the parent's array form control (if it exists!) to retrieve all the values of the child fields. Otherwise, handling any added or removed items would have been complicated and would have resulted in a lot more subscriptions.
  • The valueChanges subscription is now delayed a little by using debounceTime to reduce the event processing

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

jlipka added 2 commits June 5, 2026 11:14
- Introduced `typeBindToField` for enhanced type-binding capabilities
- Refactored type-bind relations and model handling in the form builder
- Improved subscription logic and matcher application for dynamic type-binding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant