Add a configuration option to open bitstream download in new browser tabs#5655
Open
FrancescoMolinaro wants to merge 4 commits into
Open
Add a configuration option to open bitstream download in new browser tabs#5655FrancescoMolinaro wants to merge 4 commits into
FrancescoMolinaro wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Fixes #5654
Description
Added a new configuration to allow bitstreams in item page to be opened in a new tab.
bitstreams-new-tab.webm
Instructions for Reviewers
To test the functionality set the property openDownloadLinksInNewTab as true in the configuration file and observe the behavior by clicking on a bitstream link in item page.
List of changes in this PR:
Added new configuration property openDownloadLinksInNewTab under the bitstream section to allow bitstreams in item pages to be opened in a new tab.
By default the property is set as false keeping the old behavior as the active one.
Changed html element of component from button to link.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.