Skip to content

Fixes #5633 - [i18n] Update and complete Hungarian (hu) translations for DSpace 10#5634

Open
kanasznagyzoltan wants to merge 21 commits into
DSpace:mainfrom
qultoltd:QREPO-401-DSpace-10.0-Hungarian-Translations
Open

Fixes #5633 - [i18n] Update and complete Hungarian (hu) translations for DSpace 10#5634
kanasznagyzoltan wants to merge 21 commits into
DSpace:mainfrom
qultoltd:QREPO-401-DSpace-10.0-Hungarian-Translations

Conversation

@kanasznagyzoltan
Copy link
Copy Markdown
Contributor

References

Description

This PR updates and completes the Hungarian (hu) translations for DSpace 10. It ensures full coverage for new features, including Entities, Relationships, and the improved Workflow, while fixing several syntax issues and outdated terminologies.

Instructions for Reviewers

This PR is a comprehensive update to the Hungarian localization file (hu.json5). We have performed a thorough review of the existing keys and added translations for all missing keys introduced in recent versions.

List of changes in this PR:

  • Added missing translations: Full coverage for DSpace 9 and 10 features (Entities, Custom URLs, CMS Metadata hints, LDN services).
  • Proofreading & Consistency: Reviewed existing translations to ensure they align with standard Hungarian library and repository terminology.
  • Code Cleanup: Removed several hundred lines of outdated "previous version" comments and // TODO markers to improve file maintainability.
  • Formatting: Standardized indentation to 2 spaces across the entire file.

Include guidance for how to test or review your PR.

  • Build the Angular UI with this branch.
  • Switch the language to Hungarian (Magyar) in the UI header.
  • Navigate through the following areas to verify translations:
  • Submission process: Check new metadata fields and error messages.
  • Admin UI: Verify the "Edit User Agreement" and "CMS Metadata" help texts (Markdown notices).
  • Search/Discovery: Check facets and entity-related labels.
  • Verify that no "missing key" labels (e.g., ???key???) appear in these areas.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels May 7, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release May 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Hi @kanasznagyzoltan,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

….0-Hungarian-Translations

# Conflicts:
#	src/assets/i18n/hu.json5
@kanasznagyzoltan
Copy link
Copy Markdown
Contributor Author

I have resolved the conflicts.

Copy link
Copy Markdown

@nathanmlf nathanmlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on these translations @kanasznagyzoltan!

I followed your instructions and tested the UI. Most of it looks perfect, but I found a few missing translations:

Submission process: The error messages seem to be OK. However, I found some untranslated text in the new metadata fields (they are still displaying in English).

Search/Discovery: Everything is OK.

Admin UI: "Edit User Agreement" and "CMS Metadata" are OK. However, "Filtered Collections" and "Metadata Query" are not translated. They are displaying in English, although they don't show any "missing keys".

I am attaching the screenshots below so you can see exactly where the issues are. Let me know when you update the file so I can re-test!

Submission Process:

Image

Admin UI:

Image

@github-project-automation github-project-automation Bot moved this from 🙋 Needs Reviewers Assigned to 👀 Under Review in DSpace 10.0 Release May 13, 2026
@kanasznagyzoltan
Copy link
Copy Markdown
Contributor Author

kanasznagyzoltan commented May 14, 2026

Thank you @nathanmlf for checking my PR.

image
  • I am checking why "Filtered Collections" and "Metadata Query" are not translated.

  • The metadata labels for the submission forms is coming from submission-forms.xml. This xml is originally created using EN labels, thats why a huge part of the form is untranslated.

image

I am trying to do an update soon, I hope today.

@kanasznagyzoltan
Copy link
Copy Markdown
Contributor Author

I have fixed the missing Reports related i18n keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

Status: 👀 Under Review

Development

Successfully merging this pull request may close these issues.

[i18n] Update and complete Hungarian (hu) translations for DSpace 10

3 participants