Restore "Fix current parent order when creating subcommunity" (#4568)#5269
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Mar 10, 2026
Merged
Restore "Fix current parent order when creating subcommunity" (#4568)#5269tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue merged 1 commit intoDSpace:mainfrom
Conversation
toniprieto
force-pushed
the
recover-4568
branch
from
513d02a to
2edfc0d
Compare
lgeggleston
added
bug
component: Discovery
tdonohue
approved these changes
Mar 10, 2026
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @toniprieto for catching this! I agree this was not meant to be removed as it reintroduces an older bug.
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to 👍 Reviewer Approved
in DSpace 10.0 Release
github-project-automation
bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace 10.0 Release
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
tdonohue
removed
port to dspace-7_x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
This PR restores the behavior originally introduced in #4568, which appears to have been unintentionally reverted in #4639.
The change allows retrieving the ID of the current community and using it in the initial search when opening the community selector popup when creating a community.
Instructions for Reviewers
How to test:
FindAddAuthorizedincludes the ID of the current community.Ideally, the first result shown should be the current community.
However, the current behavior is not fully perfect. In my tests, when the current community has subcommunities, the subcommunities are often listed first. This happens because the parent community ID is indexed in several fields of the child communities and tends to have higher relevance.
This issue would likely be better addressed in the backend in future PRs. Nevertheless, restoring this change improves the current behavior.