Skip to content

Conversation

@guillermo-escire
Copy link
Contributor

@guillermo-escire guillermo-escire commented Jan 26, 2026

References

Description

This PR improves internationalization support for submission alerts when new sections are dynamically added.
Instead of using a partially translatable message, the alert now supports fully translatable i18n keys per section, with a fallback to the generic message when a specific translation is not available.

Summary of changes

  • Updated submission.service.ts to generate section-specific i18n keys for the “new section added” alert.
  • Allows translations to be defined per section (e.g. duplicates) while maintaining backward compatibility via a fallback key.

Instructions for Reviewers

  1. Start the Angular UI and create a new submission.
  2. Add metadata that triggers a new section to appear (for example, trigger the duplicates section by submitting metadata that already exists in the database).
  3. Observe the notification alert shown in the upper-right corner.
  4. Verify that:
    • The alert message is fully translatable.
    • A section-specific i18n key is used when available.
    • The generic fallback message is used if no section-specific translation exists.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue
Copy link
Member

@guillermo-escire : Please add a description to this PR including how to test it. All PRs must provide basic instructions for how reviewers are to test them. I've already added the link back to the issue you are fixing (which is also required), but I'll leave the rest of the description for you to fill out.

@tdonohue tdonohue added bug i18n / l10n Internationalisation and localisation, related to message catalogs component: submission 1 APPROVAL pull request only requires a single approval to merge labels Jan 27, 2026
@tdonohue tdonohue added port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Jan 27, 2026
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: submission i18n / l10n Internationalisation and localisation, related to message catalogs port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

Alert for new sections not fully translatable

2 participants