Skip to content

Conversation

@tinsch
Copy link

@tinsch tinsch commented Jan 22, 2026

Description

This PR reduces the number of calls to the REST API by executing certain authorization requests only conditionally if the normal download is not possible for the user. Before, the authorization request "canRequestACopy" was always sent for every bitstream, now this only happens if the "canDownload" request returns false. This improves the response time performance for items with a large number of bitstreams and a large pagesize (>=50), as can be seen in a graph below.

Instructions for Reviewers

Currently the response time is slow for items with a large number of bitstreams. The current workaround are small pageSizes for the item's bitstreams per default. However, from a UX standpoint it would be nice to be able to show a larger list of bitstreams to the users, especially in the case of uploaded research data.

How to test this PR:

  • create an Item with >=50 bitstreams
  • edit some bitstreams, so that they are embargoed, or the access is otherwise restricted to anonymous users
  • set item.bitstream.pageSize to 50 (or more)
  • check that the response time is slower without this PR on the item page, and faster with the PR changes
  • check that the "Request a copy" functionality still works for embargoed and otherwise restricted items

Here is a comparison of the reponse time of an item page, varied in the page size:
response-times-compared

Related Issues, former issues with item bitstream pagesize:

DSpace/DSpace#8648
#2065

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Co-funded by the European Union and Universitätsbibliothek TU Berlin (DSpaceQPO project)

@tinsch tinsch added the performance / caching Related to performance, caching or embedded objects label Jan 22, 2026
@tinsch tinsch changed the title Reduce bitstream authorization requests Reduce bitstream authorization requests for item page Jan 26, 2026
@tinsch tinsch marked this pull request as ready for review January 26, 2026 13:09
@tinsch
Copy link
Author

tinsch commented Jan 26, 2026

Please note: I am not a frontend dev, so I would be grateful for a review by a more experienced frontend developer :) especially concerning the revised tests

@tdonohue tdonohue added high priority 1 APPROVAL pull request only requires a single approval to merge labels Jan 26, 2026
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge high priority performance / caching Related to performance, caching or embedded objects

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

2 participants