[Port dspace-8_x] [Docker] Fix networking and startup issues with Docker Compose scripts. Update scripts to align with best practices #4995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e comments. Use Dockerfile best practices for ENTRYPOINT vs CMD.
…d. Use best practices for ENTRYPOINT vs CMD
…. This allows production mode to fully work again.
…ing the `--poll` flag to serve command.
…cker images/scripts are working properly.
tdonohue
added
bug
1 APPROVAL
tdonohue
changed the title
github-project-automation
bot
moved this to ✅ Done
in DSpace Maintenance (9.x, 8.x, 7.6.x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual port of #4987 to
dspace-8_x. Features specific to 9.x+ were not included in this port (e.g. 8.x usesyarninstead ofnpm, sonpmspecific changes are excluded)NOTE: Because this version uses
yarninstead ofnpm, I've manually tested that both the Development mode and Production mode work properly. I also verified that Development mode will automatically rebuild/reload if you change code in thesrcdirectory.