Skip to content

Solr-based suggestion / autocomplete#4439

Draft
kshepherd wants to merge 1 commit intoDSpace:mainfrom
the-library-code:feature/TLC-790_solr_suggest_main
Draft

Solr-based suggestion / autocomplete#4439
kshepherd wants to merge 1 commit intoDSpace:mainfrom
the-library-code:feature/TLC-790_solr_suggest_main

Conversation

@kshepherd
Copy link
Member

@kshepherd kshepherd commented Jun 5, 2025

Adds Solr-based suggestion to dynamic onebox vocabulary lookups.

See DSpace/DSpace#10855 for more notes

UI
In the dynamic-onebox Angular component which traditionally handles vocabulary / authority display like tree lookup or autocomplete, if the vocabulary type is "suggest", it will use a different search method and display template for the suggest terms. If not, the current behaviour is used (lookup / suggest from XML / etc)

Like the backend, the actual suggest term JSON is not fully modelled in Angular, it is just treated as JSON. This is done to keep things light (they are not proper DSpace addressable objects or anything, not used anywhere but as input providers) and due to the structure of the JSON where terms are used as key names, etc.

f31100b4-99df-4f9e-91cb-341cb6b66c3b

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

Hi @kshepherd,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

@strawburster strawburster force-pushed the feature/TLC-790_solr_suggest_main branch from 5b7602f to 6c6f045 Compare January 28, 2026 15:19
@strawburster
Copy link

I'm trying to limit the number of new properties on the onebox component, which is already quite a monstrous little thing. I combined the suggestion api and the vocabulary service into a single observable, and I want to combine the suggestrt/suggestrte templates with the existing rt and rte templates. Other than that, this is working as expected. I may adjust the spinner stylistically.

@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Jan 30, 2026
@strawburster strawburster force-pushed the feature/TLC-790_solr_suggest_main branch 2 times, most recently from 1749b53 to bca4d58 Compare February 4, 2026 11:09
@strawburster strawburster force-pushed the feature/TLC-790_solr_suggest_main branch from bca4d58 to 48550ca Compare February 4, 2026 12:04
@strawburster
Copy link

This is working the way I want it to. I made large changes to the onebox component, and I plan on adding more tests for it, as well as tests for the new search service method for getting suggestions. The existing tests should all pass (famous last words)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

3 participants