-
Notifications
You must be signed in to change notification settings - Fork 508
Allow input of alternative text for collection and community logos/th… #3389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
07d489b
cc74739
3fe8375
0ab24be
296d4fb
909aa99
cb75276
c78b775
5affeb1
a90c02c
b140ca0
0254f3d
3ed8b29
cc0bbc8
daa04ca
2e58674
837d5c0
3c9002b
041a243
d7716ac
a1e206a
b364abc
800349e
5b94a64
94547fb
32f95b3
8bd7a43
a32bd05
e41f1ac
b60f9ea
e8d71ae
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,8 +7,13 @@ | |
| <header class="comcol-header me-auto"> | ||
| <!-- Community name --> | ||
| <ds-comcol-page-header [name]="dsoNameService.getName(communityPayload)"></ds-comcol-page-header> | ||
| <!-- Community logo --> | ||
| @if (logoRD$) { | ||
| <!-- Community logo with custom description --> | ||
| @if (logoRD$ && communityPayload.descriptionThumbnail) { | ||
| <ds-comcol-page-logo [logo]="(logoRD$ | async)?.payload" [alternateText]="communityPayload.descriptionThumbnail"> | ||
| </ds-comcol-page-logo> | ||
| } | ||
| <!-- Community logo with simple description --> | ||
| @if (logoRD$ && !communityPayload.descriptionThumbnail) { | ||
|
Comment on lines
+10
to
+16
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here |
||
| <ds-comcol-page-logo [logo]="(logoRD$ | async)?.payload" [alternateText]="'community.logo' | translate"> | ||
| </ds-comcol-page-logo> | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -130,6 +130,14 @@ export class Collection extends DSpaceObject implements ChildHALResource, Handle | |
| return this.firstMetadataValue('dc.description.tableofcontents'); | ||
| } | ||
|
|
||
| /** | ||
| * The thumbail description of this Collection | ||
| * Corresponds to the metadata field dspace.thumbnail.description | ||
| */ | ||
| get descriptionThumbnail(): string { | ||
| return this.firstMetadataValue('dspace.thumbnail.description'); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was suggested in today's meeting that the more appropriate place to store the "alt" text for a Bitstream would be on the Bitstream object itself in the
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree with @tdonohue's comment here |
||
| } | ||
|
|
||
| getParentLinkKey(): keyof this['_links'] { | ||
| return 'parentCommunity'; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be optimized the same way you did for the thumbnail component, by conditionally setting the value of alternateText