Skip to content

Conversation

@jwillemsen
Copy link
Member

@jwillemsen jwillemsen commented Jan 23, 2026

* templates/bmakecommon.mpt:

Summary by CodeRabbit

  • Chores
    • Updated build configuration compiler warning settings in the bcc64x configuration block.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

The bcc64x build configuration in the template file is adjusted to relocate the -Wno-ignored-attributes compiler flag from release_flags to common_flags, applying the warning suppression across all build variants instead of only release builds.

Changes

Cohort / File(s) Summary
Build Configuration
templates/bmakecommon.mpt
Moved -Wno-ignored-attributes flag from release_flags to common_flags in bcc64x configuration block

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A flag hops from release to the common ground,
Where all builds can silence warnings with a bound,
No more selective suppression, just a single way—
The config grows wiser, hooray, hooray!

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jwillemsen jwillemsen merged commit cf625a7 into DOCGroup:master Jan 23, 2026
10 of 11 checks passed
@jwillemsen jwillemsen deleted the jwi-ignoredatt branch January 23, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant