Fix eslint rule typo: backgroundDismiss → backdropDismiss#1437
Merged
valadas merged 2 commits intorelease/0.27.8from Jan 26, 2026
Merged
Fix eslint rule typo: backgroundDismiss → backdropDismiss#1437valadas merged 2 commits intorelease/0.27.8from
valadas merged 2 commits intorelease/0.27.8from
Conversation
Co-authored-by: valadas <6371568+valadas@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix eslint plugin typo in backgroundDismiss
Fix eslint rule typo: backgroundDismiss → backdropDismiss
Jan 26, 2026
valadas
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eslint rule
dnn-modal-no-background-dismisswas checking forbackgroundDismissinstead of the correct property namebackdropDismiss, causing it to never trigger on the deprecated property.Changes
backgroundDismisstobackdropDismissand autofix suggestion frompreventBackgroundDismisstopreventBackdropDismissExample
The rule now correctly detects:
The correct property names match the actual component implementation in
dnn-modal.tsxwhich definesbackdropDismissandpreventBackdropDismiss.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.