Table extensions examples #721
Conversation
fstagni
force-pushed
the
table_extensions_examples
branch
from
d6e65f9 to
7d97288
Compare
| # NOTE: We need to remove the original Jobs table from metadata because | ||
| # GubbinsJobs modifies an existing column (job_name size from 128 to 512). | ||
| # Simple inheritance works fine for ADDING columns (see GubbinsInputData below), | ||
| # but MODIFYING existing columns in SQLAlchemy requires replacing the table definition. |
There was a problem hiding this comment.
MODIFYING existing columns
IIRC we had said that we didn't want to support this, do you have a use case in mind?
There was a problem hiding this comment.
Personally I do not have a use case for this, but such an example was asked by CMS.
There was a problem hiding this comment.
We explicitly said we would not do that because it has too many implications. We will even have to modify some LHCb database to follow that.
There was a problem hiding this comment.
I can't (nor @aldbr , and probably no-one can) remember that this was said, and it is not in https://diracx.diracgrid.org/en/latest/dev/explanations/extensions/
So, this explicitly shows that at the moment this is the way to go if someone wants to do this.
There was a problem hiding this comment.
We explicitly said we would not do that because it has too many implications. We will even have to modify some LHCb database to follow that.
Is that written anywhere in the documentation?
I found that block of documentation about DB extensions, but it's not explicitly mentioned: https://diracx.diracgrid.org/en/latest/dev/explanations/extensions/#extended-db
If not written anywhere, I think we should clearly mention it there (this section of the documentation is probably the right place)
(In the future, as we discussed, this should likely go through a Github Issue for discussion first)
4 participants
No description provided.