-
Notifications
You must be signed in to change notification settings - Fork 31
feat: Implement PilotAgents schema #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceedc87 to
b8b1ef1
Compare
aldbr
reviewed
Sep 19, 2024
12ab34d to
359e965
Compare
aldbr
reviewed
Oct 7, 2024
Contributor
aldbr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost fine, I am just curious about executemany versus execute n times.
Co-authored-by: aldbr <aldbr@outlook.com>
2a9a426 to
9953ddb
Compare
aldbr
reviewed
Oct 10, 2024
aldbr
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (along with #112 is necessary to be able to get pilot ID from a pilot stamp in pilot logging code (#269). It only implements the DB schema and a method to store pilot references in it.
PilotAgentsrelated tables. Add PilotAgentsDB topyproject.toml.addPilotReferencesindb.py