Reintroduce useSWR #409
Draft
Reintroduce useSWR #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to: #408
As suggested in that PR, I reintroduced
useSWRto avoid fetching resources on every mount.The results are as expected. However, when opening the module for the very first time, no data is fetched, since we explicitly prevent fetching on every mount. The initial mount is therefore treated just like any other remount. This point still needs to be addressed.
One possible approach would be to use a
useEffectthat checks if the data is null and there is no error (which should normally never happen in our model), and then triggers a mutate on the key.