Skip to content

Conversation

@fstagni
Copy link
Contributor

@fstagni fstagni commented Oct 24, 2025

  • add unit test

@fstagni fstagni force-pushed the preferredURLPattern branch from 5b02055 to 984c98d Compare October 28, 2025 09:22
@fstagni fstagni marked this pull request as ready for review October 28, 2025 09:50
@chrisburr
Copy link
Member

How am I suposed to review this with hundreds of lines of formatting changes mixed in to the same commit?

return len(preferredURLPatterns)


def orderCSByPatterns(configServerList, preferredURLPatterns):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? I thought the pilot only put the CS URL(s) into the pilot.cfg which is then parsed by a full DIRAC installation which will randomize/order them correctly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue I was trying to solve here is the first contact to the CS: which one to use.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell this is only ordering the URLs in the pilot.cfg file? Or am I missing something?

If so, the sorting/randomisation is done here: https://github.com/chrisburr/DIRAC/blob/b17cf052b5e23912da1a9e7accfe65b7632e7457/src/DIRAC/ConfigurationSystem/private/RefresherBase.py#L141-L144

@fstagni fstagni closed this Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants