fix(CSAPI): return AffiliationEnds from describeUsers #8398
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresailer
reviewed
Dec 8, 2025
| if "AffiliationEnds" in user_sections: | ||
| affiliation_ends_opts = self.__csMod.getOptions(f"{csSection}/AffiliationEnds") | ||
| for vo_ in affiliation_ends_opts: | ||
| affiliation_ends_current[vo_] = self.__csMod.getValue(f"{csSection}/AffiliationEnds/{vo_}") |
Contributor
There was a problem hiding this comment.
Can't you just use
Construct the whole path and call getOptionsDict
# getOptionsDict returns S_ERROR if missing section
return self.__csMod.getOptionsDict(f"{theSections}").get("Value", {})
Contributor
Author
There was a problem hiding this comment.
Yes it seems that getOptionsDict is the right option here, but I can't be sure that it'll work as expected (particularly since it doesn't seem to return S_ERROR on missing section)
I will integrate it when I have time, but I don't currently trust it and this shouldn't block the next release, since there is a hotfix that depends on this PR
fstagni
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
*CSAPI
FIX: Have CSAPI return AffiliationEnds if existing
ENDRELEASENOTES