feat: create DIRACCommon package for stateless utilities #8287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisburr
force-pushed
the
dirac-common
branch
10 times, most recently
from
6b5225c to
784842e
Compare
Contributor
|
note for myself when reviewing: integration-tests.py should install DIRACCommon in editable mode |
chrisburr
force-pushed
the
dirac-common
branch
from
784842e to
85a5084
Compare
fstagni
reviewed
Aug 26, 2025
| CLIENT_UPLOAD_LFN: LFN:/vo/test_lfn.txt | ||
| CLIENT_UPLOAD_FILE: test_lfn.txt | ||
| PILOT_INSTALLATION_COMMAND: dirac-pilot.py --modules /home/dirac/LocalRepo/ALTERNATIVE_MODULES/DIRAC -M 2 -N jenkins.cern.ch -Q jenkins-queue_not_important -n DIRAC.Jenkins.ch --pilotUUID=whatever12345 --CVMFS_locations=/home/dirac/ -o diracInstallOnly --wnVO=vo --debug | ||
| PILOT_INSTALLATION_COMMAND: dirac-pilot.py --modules /home/dirac/LocalRepo/ALTERNATIVE_MODULES/DIRAC/dirac-common,/home/dirac/LocalRepo/ALTERNATIVE_MODULES/DIRAC -M 2 -N jenkins.cern.ch -Q jenkins-queue_not_important -n DIRAC.Jenkins.ch --pilotUUID=whatever12345 --CVMFS_locations=/home/dirac/ -o diracInstallOnly --wnVO=vo --debug |
Contributor
There was a problem hiding this comment.
The same file needs to be changed also in LHCbDIRAC
docs/source/UserGuide/GettingStarted/InstallingClient/index.rst
Outdated
Show resolved
Hide resolved
Contributor
|
What is the reason for releasing DIRACCommon every time there's a DIRAC release? |
chaen
reviewed
Aug 26, 2025
chaen
reviewed
Aug 26, 2025
chrisburr
commented
Aug 28, 2025
docs/source/UserGuide/GettingStarted/InstallingClient/index.rst
Outdated
Show resolved
Hide resolved
chrisburr
force-pushed
the
dirac-common
branch
from
e2318e0 to
b29c8ab
Compare
chrisburr
force-pushed
the
dirac-common
branch
2 times, most recently
from
1b7a847 to
c0c3465
Compare
fstagni
reviewed
Aug 28, 2025
docs/source/UserGuide/GettingStarted/InstallingClient/index.rst
Outdated
Show resolved
Hide resolved
Extract ReturnValues and DErrno to separate DIRACCommon package to solve circular dependencies where DiracX needs DIRAC utilities without global state initialization. - Create DIRACCommon package with stateless utilities - Maintain backward compatibility in original DIRAC locations - Add independent testing and CI workflows - Configure automated deployment for both packages 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
chrisburr
force-pushed
the
dirac-common
branch
from
c0c3465 to
848932a
Compare
chaen
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extracts stateless utilities from DIRAC into a new
DIRACCommonpackage to resolve circular dependency issues between DIRAC and DiracX. DIRACCommon contains only stateless utilities (ReturnValues, DErrno) that can be safely imported without triggering DIRAC's global state initialization.The package is co-released with DIRAC and shares its version number.
Note: This PR requires DIRACGrid/Pilot#265 to be merged first.
Fixes #8285
BEGINRELEASENOTES
*Core
NEW: DIRACCommon package containing stateless utilities extracted from DIRAC. This allows external projects like DiracX to use DIRAC's S_OK/S_ERROR return values and error codes without importing DIRAC and triggering global state initialization. The package maintains full backward compatibility - all existing imports continue to work unchanged.
ENDRELEASENOTES