Skip to content

[8.0] Add wait timeout when connecting to stomp #8057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisburr wants to merge 1 commit into
base: rel-v8r0
Choose a base branch
from
Open

[8.0] Add wait timeout when connecting to stomp #8057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/DIRAC/Resources/MessageQueue/StompMQConnector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,10 +200,14 @@ def connect(self, parameters=None):

for _ in range(10):
try:
# We need to explicitely call disconnect to avoid leaving
# threads behind
# We need to explicitly call disconnect to avoid leaving threads behind
self.connection.disconnect()
self.connection.connect(username=user, passcode=password, wait=True)

# Connect to the broker with a timeout of 30 seconds
self.connection.connect(username=user, passcode=password, wait=False)
Copy link
Contributor

@chaen chaen Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is exactly what wait = True does

https://github.com/jasonrbriggs/stomp.py/blob/0f8fe0f398604ced511613fcdbd1fa78a8d06a0a/stomp/protocol.py#L338-L341

Copy link
Member Author

@chrisburr chrisburr May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't as wait=True blocks forever and doesn't have a timeout.

self.transport.wait_for_connection(30) # pylint: disable=no-member
if self.transport.connection_error: # pylint: disable=no-member
raise stomp.exception.ConnectFailedException()

if self.connection.is_connected():
# Go to the socket of the Stomp to find the remote host
Expand Down
Loading