Reduced diameter of star as thickness increases to fit within bounding box #1445
Conversation
changelog.txt
Outdated
|
|
||
| ## Fixes | ||
|
|
||
| - `gui/design`: reduced diameter of star as thickness increases to remain within bounding box |
There was a problem hiding this comment.
no need for a "fixes" line for the star shape since it hasn't been out in a release yet. However, if this fixes the bulge for the line shape, I'd say that deserves a "fixes" entry.
There was a problem hiding this comment.
What's the bulge in the line shape issue?
There was a problem hiding this comment.
Made the horizontal and vertical thickness consistent for curved lines as well, maybe this is the bulge you were referring to.
There was a problem hiding this comment.
The bulge in the line shape was similar to what was happening for the star. When increasing the line thickness, the designated tiles can bulge beyond the selected endpoint, leading to potentially "selecting" tiles that are outside of the map:
This PR fixes the star shape, but the line still suffers from bulging.
I'll merge this PR as-is because the line bulge was a pre-existing issue, but if you have ideas on how to fix that, I'd love to hear them
|
I'm not sure if this fixes the issue. I was still able to draw a star that extended beyond the edge of the map: |
When I draw this exact size star I get the following result: 
Am I missing something? |
I'll test again, likely not properly synced on my part |
2 participants
Reduced diameter of hollow star as the thickness increases so it does not exceed its bounding box.
Adjusted original changelog entry to contain more details about usage.