Skip to content

Conversation

@ryanbennitt
Copy link
Contributor

gui/design

Add new option to draw N-point stars.

  • The default has 5 points, use 'B'/'b' to increase/decrease points.
  • They can be hollow or filled, and inverted.
  • The next-point offset can be increased/decreased using 'N'/'n' which particularly affects 7 point stars and above to make them spikier or smoother, but can also be used to decrease to 1 to make symmetrical polygons or increase to N which only paints the vertexes.
  • The orientation can be changed by adding a main axis point using 'v' and moving this to point in the desired direction.

Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 100% awesome!

The only issue I found (from play testing) is that the drawn lines can now exceed the bounding box. This is especially visible when Invert is on:

image

When thickness is increased, could the lines be made to expand towards the center?

Star.ATTRS {
name = "Star",
texture_offset = 25,
button_chars = util.make_ascii_button('*', 15),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice choice

@myk002
Copy link
Member

myk002 commented Apr 27, 2025

I think I'll approve this for now, and we can discuss the bulging issue on Discord

@github-project-automation github-project-automation bot moved this from Todo to Review In Progress in 51.11-r2 Apr 27, 2025
@myk002 myk002 merged commit 0f8985b into DFHack:master Apr 27, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in 51.11-r2 Apr 27, 2025
@ryanbennitt ryanbennitt deleted the feature/design_star branch May 6, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants