Fixing gui/mod-manager not loading #5524
Conversation
| local path = ol.object_load_order_src_dir[idx] | ||
| local path = nil | ||
| if ol.object_load_order_src_dir[idx] then | ||
| path = ol.object_load_order_src_dir[idx].value |
There was a problem hiding this comment.
src_dir is a vector<path> in 52.02 and so its elements do not have the .value metamethod. This code will not work with 52.02, or against develop
|
Please confirm that the bug you're trying to fix here hasn't already been fixed in dev. |
|
Will do, if it's fixed in dev then I'll close out the PR here. |
|
Alright, it's resolved in dev, gonna close out this PR and the Issue. May I ask when you all plan to drop the change in as a release? |
|
rome said this in Discord # planning |
|
Cool, thank you both for your time and best of luck with the release to you all! 👋 😄 |
3 participants
Not sure if this mod makes an externally visible change in this case, but it should fix the issue I encountered in #5519
Also, I ended up adding my name to Authors.rst for the fix. I hope that's fine.