-
Notifications
You must be signed in to change notification settings - Fork 82
add support for properly typed maps #862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5cda3b6 to
2a7ea79
Compare
|
moving this to draft until i sort out the hashing stuff and add identity support for |
|
wow. this is going to be a nightmare. have to write hash functions for all the structs like |
|
I believe these errors is due to failure from having no hash function. I manually patched Which you probably already know...so. |
|
I guess the == operator could be done that way for now? and I suppose could add hash specializations to std namespace so that unordered_map doesn't need a 3rd argument. |
Yes, indeed. The issue is coming up with a way to get these to exist in a clean way via codegen. I have a kernel of an idea on how to do it, but I've already blown my peak programming time for today on other stuff, so I'm going to push this to tomorrow. also the error above is actually because we don't have an |
These changes allow codegen to produce properly typed C++
std::mapandstd::unordered_mapobjects in generated structures