Skip to content

Conversation

@quietust
Copy link
Member

@quietust quietust commented Nov 4, 2025

to automatically infer the length based on the values in the enum, so that when Toady adds new enum entries we don't end up missing them.

No structures should report any size differences (aside from enum types being created or renamed) - if they do, it means I made a mistake somewhere.

@quietust quietust force-pushed the fixes branch 3 times, most recently from b88e94f to c5eb76c Compare November 4, 2025 00:57
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

The sizes of the following types have changed in this pull request. Please verify that this is intentional. Note that renamed types are not currently detected and will also be listed here.

Type Platform Previous size New size (this PR) Change
barrack_preference_category linux64 4 2 -2
barrack_preference_category windows64 4 2 -2
infrastructure_type linux64 0 4 +4
infrastructure_type windows64 0 4 +4
init_load_bar_texture_type linux64 0 4 +4
init_load_bar_texture_type windows64 0 4 +4
keybinding_category linux64 4 0 -4
keybinding_category windows64 4 0 -4
keybinding_category_type linux64 0 4 +4
keybinding_category_type windows64 0 4 +4
text_set_type linux64 0 4 +4
text_set_type windows64 0 4 +4
texture_type linux64 0 4 +4
texture_type windows64 0 4 +4
trade_category_type linux64 0 4 +4
trade_category_type windows64 0 4 +4

This is an automated comment. Please leave a reply if you think that the above information is incorrect.

@quietust
Copy link
Member Author

quietust commented Nov 4, 2025

All type size changes listed above are expected; however, some DFHack code changes are required in order to cope with this update (DFHack::Gui::addCombatReport needs to tolerate the "NONE" enum member).

@quietust quietust force-pushed the fixes branch 2 times, most recently from 71747d5 to cca620c Compare November 10, 2025 18:37
to automatically infer the length based on the values in the enum, so
that when Toady adds new enum entries we don't end up missing them.
ab9rf added a commit to ab9rf/dfhack that referenced this pull request Nov 17, 2025
@ab9rf ab9rf merged commit 7ba825f into DFHack:master Nov 17, 2025
18 of 24 checks passed
@quietust quietust deleted the fixes branch November 17, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants