Skip to content

add default values for material and mat_index in `reaction_reagen… #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ab9rf merged 2 commits into from
Aug 18, 2025
Merged

add default values for material and mat_index in `reaction_reagen… #848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a6b574
add default values for `material` and `mat_index` in `reaction_reagen…
ab9rf Aug 17, 2025
1bd7a15
`init-value` not `default-value`
ab9rf Aug 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Template for new versions:
# Future

## Structures
- added default values for ``material`` and ``mat_index`` in ``reaction_reagentst`` and ``reaction_productst`` child classes

# 52.03-r1.1

Expand Down
12 changes: 6 additions & 6 deletions df.reaction.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@
<class-type type-name='reaction_reagent_itemst' inherits-from='reaction_reagent'>
<enum base-type='int16_t' name='item_type' type-name='item_type'/>
<int16_t name='item_subtype' refers-to='(item-subtype-target $$._parent.item_type $)'/>
<int16_t name='mat_type' ref-target='material' aux-value='$$.mat_index'/>
<int16_t name='mat_index'/>
<int16_t name='mat_type' ref-target='material' aux-value='$$.mat_index' init-value='-1'/>
<int16_t name='mat_index' init-value='-1'/>

<stl-string name='reaction_class'/>
<stl-string name='has_material_reaction_product'/>
Expand Down Expand Up @@ -131,8 +131,8 @@
<class-type type-name='reaction_product_itemst' inherits-from='reaction_product'>
<enum base-type='int16_t' name='item_type' type-name='item_type'/>
<int16_t name='item_subtype' refers-to='(item-subtype-target $$._parent.item_type $)'/>
<int16_t name='mat_type' ref-target='material' aux-value='$$.mat_index'/>
<int32_t name='mat_index'/>
<int16_t name='mat_type' ref-target='material' aux-value='$$.mat_index' init-value='-1'/>
<int32_t name='mat_index' init-value='-1'/>

<int16_t name='probability'/>
<int16_t name='count'/>
Expand Down Expand Up @@ -161,8 +161,8 @@
<enum name='improvement_type' type-name='improvement_type'/>
<enum base-type='int32_t' name='improvement_specific_type' type-name='itemimprovement_specific_type'/>

<int16_t name='mat_type' ref-target='material' aux-value='$$.mat_index'/>
<int32_t name='mat_index'/>
<int16_t name='mat_type' ref-target='material' aux-value='$$.mat_index' init-value='-1'/>
<int32_t name='mat_index' init-value='-1'/>

<int16_t name='probability'/>

Expand Down
Loading