Skip to content

Conversation

@leandrolanzieri
Copy link

Description

In many cases it may be useful to monitor the evolution process as it happens. As the complete algorithms provide no callback while running, a reasonable entry point is the logbook. The user can create a custom Logbook class that processes statistics as they are recorded (e.g., writing to a tensorboard writer).

This PR suggests that algorithms accept an optional logbook parameter that the user can instantiate. When not provided, the behaviour remains the same.

@leandrolanzieri leandrolanzieri changed the title algorithms: accept optional logbook instance algorithms: Accept optional logbook instance Sep 19, 2025
@fmder
Copy link
Member

fmder commented Sep 23, 2025

I like your PR, the only thing that I'm wondering is the signature change for those using only positional arguments.

@leandrolanzieri
Copy link
Author

I like your PR, the only thing that I'm wondering is the signature change for those using only positional arguments.

Right. I'll move the logbook to the end so it doesn't affect those users.

@leandrolanzieri leandrolanzieri force-pushed the pr/algorithms_accept_logbook branch from d23d330 to 7e00e89 Compare September 23, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants