fix(registry): remove duplicate BLAKE2b-HMAC variant (#752)#753
Conversation
|
cc: @bhess |
bhess
left a comment
There was a problem hiding this comment.
Thank you for highlighting this issue, @Mehrn0ush. Please see my inline comment, it seems to be a typo that caused the duplicate.
4e67374 to
f2a2652
Compare
There was a problem hiding this comment.
Pull request overview
This PR addresses data quality issues in the Cryptography Registry by removing a duplicate BLAKE2b-HMAC variant and correcting several other typos and omissions.
Changes:
- Removed duplicate BLAKE2b-HMAC variant entry by changing it to BLAKE2s-HMAC
- Added missing AES-GCM-SIV variant with RFC 8452 standard reference
- Fixed TUAC typo to TUAK in two pattern definitions
- Fixed bcrypt pattern syntax error (parenthesis to brace)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f2a2652 to
bcc248b
Compare
bcc248b to
b714d1a
Compare
|
Hi all, I’ve cleaned up the branch so that it now only includes the intended change from issue #752: correcting the BLAKE2s-HMAC variant typo. All unrelated changes (TUAC→TUAK, AES-GCM-SIV addition, bcrypt syntax) have been removed, and the branch is now fully aligned with the original scope of #752. This branch is ready for review/merge. Thanks! |
bhess
left a comment
There was a problem hiding this comment.
Thanks for the update @Mehrn0ush, LGTM.
As discussed in ticket #752, this PR fixes a data-quality issue in the Cryptography Registry.
Fixes #752
Details
BLAKE2b-(160|256|384|512)-HMACvariant entry (primitive: mac)Scope
schema/cryptography-defs.json)