fix: add missing modelCard.properties to XML + Protobuf schemas#743
fix: add missing modelCard.properties to XML + Protobuf schemas#743wiebe-vandendriessche wants to merge 4 commits intoCycloneDX:masterfrom
Conversation
…tch with json Signed-off-by: wievdndr <wiebe.vandendriessche@ugent.be>
Signed-off-by: wievdndr <wiebe.vandendriessche@ugent.be>
There was a problem hiding this comment.
Pull request overview
This PR addresses a schema inconsistency where modelCard supported a properties field in JSON schemas but was missing it in the XML (XSD) and Protobuf schemas. The fix adds the optional properties field to all three schema formats across versions 1.5, 1.6, and 1.7.
Changes:
- Added optional
propertieselement tomodelCardTypein XML schemas for versions 1.5, 1.6, and 1.7 - Added
propertiesfield (field number 5) toModelCardmessage in Protobuf schemas for versions 1.5, 1.6, and 1.7
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| schema/bom-1.5.xsd | Added optional properties element to modelCardType definition |
| schema/bom-1.5.proto | Added properties field (number 5) to ModelCard message |
| schema/bom-1.6.xsd | Added optional properties element to modelCardType definition |
| schema/bom-1.6.proto | Added properties field (number 5) to ModelCard message |
| schema/bom-1.7.xsd | Added optional properties element to modelCardType definition |
| schema/bom-1.7.proto | Added properties field (number 5) to ModelCard message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: wievdndr <wiebe.vandendriessche@ugent.be>
wiebe-vandendriessche
force-pushed
the
fix/modelcard-missing-properties
branch
from
5ade14e to
f1b7301
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…proto) Signed-off-by: wievdndr <wiebe.vandendriessche@ugent.be>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This should be ready now, @jkowalleck ? |
1 participant
As discussed in ticket #726 and in CycloneDX/cyclonedx-python-lib#914, this PR fixes a schema mismatch where modelCard supports properties in JSON but was missing it in XML and Protobuf.
Changes:
Add optional properties to modelCardType in XML schemas:
bom-1.5.xsd,bom-1.6.xsd,bom-1.7.xsdAdd properties to ModelCard Protobuf message:
bom-1.5.proto,bom-1.6.proto,bom-1.7.protoThis is backward compatible (adds optional fields only).
fixes #726