ToolInformation - Equals, HashCode, and multi-tool parsing fixes w/tests#396
Open
gdgib-roche wants to merge 3 commits intoCycloneDX:masterfrom
Open
ToolInformation - Equals, HashCode, and multi-tool parsing fixes w/tests#396gdgib-roche wants to merge 3 commits intoCycloneDX:masterfrom
gdgib-roche wants to merge 3 commits intoCycloneDX:masterfrom
Conversation
gdgib-roche
commented
Apr 18, 2024
- The new ToolInformation class did not have equals & hashCode methods, which prevented equality checks during downstream unit testing
- The custom deserializer for ToolInformation did not correctly handle multiple components & services, in XML format due to the way jackson nests the nodes
Author
|
Just added a unit test for serialization along with fixes to that too. FWIW, the previous code was semi-symmetrical across serialization & deserialization, it just also didn't work or generate/parse the expected XML. My sympathy to whoever had to understand the jackson internals enough to do this, I find them sometime frustratingly complex and I'm an expert on this kind of stuff. |
Author
|
Will look into the failing workflow next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.