chore(deps): bump x/net 0.54.0 -> 0.55.0 and x/crypto 0.51.0 -> 0.52.0 (govulncheck fix)#4496
Merged
ValClarkson merged 1 commit intoMay 22, 2026
Conversation
Fixes the govulncheck failure that is currently red on main and on every PR. The blocking finding is a Symbol-level vulnerability in our test helpers: Vulnerability #1: GO-2026-5026 Invoking failure to reject ASCII-only Punycode-encoded labels in golang.org/x/net/idna Module: golang.org/x/net Found in: golang.org/x/net@v0.54.0 Fixed in: golang.org/x/net@v0.55.0 Example traces found: #1: internal/testing/require/kubernetes.go:93:37: require.KubernetesAtLeast calls discovery.DiscoveryClient.ServerVersion, which eventually calls idna.ToASCII The same scan also reports 18 module-level (uncalled) vulnerabilities, which this bump clears as a side-effect: * 5 more golang.org/x/net/html vulns: GO-2026-5025/5027/5028/5029/5030 (fixed in x/net v0.55.0) * 13 golang.org/x/crypto/ssh* vulns: GO-2026-5005/5006/5013/5014/5015/5016/5017/5018/5019/5020/ GO-2026-5021/5023/5033 (fixed in x/crypto v0.52.0) Compatibility check: * k8s.io/api, k8s.io/apimachinery, k8s.io/client-go @ v0.36.1 each require x/net >= v0.49.0 (we go to v0.55.0) * sigs.k8s.io/controller-runtime @ v0.24.1 requires x/net >= v0.49.0 (we go to v0.55.0) Both bumps are minor patch releases on the golang.org/x/* track, with no breaking changes. 'go mod tidy' additionally bumped x/sys v0.44.0 -> v0.45.0 to satisfy the new x/crypto/x/net requirement. This patch should also be back-ported to REL_5_8, which is on the same vulnerable versions. Refs: https://pkg.go.dev/vuln/GO-2026-5026 https://pkg.go.dev/vuln/GO-2026-5005 https://pkg.go.dev/vuln/GO-2026-5023 Co-authored-by: Cursor <cursoragent@cursor.com>
crunchyheath
approved these changes
May 22, 2026
ValClarkson
added a commit
that referenced
this pull request
May 22, 2026
Backport of the same fix opened against main in #4496. Fixes the govulncheck failure that is currently red on REL_5_8. The blocking finding is a Symbol-level vulnerability in our test helpers: Vulnerability #1: GO-2026-5026 Invoking failure to reject ASCII-only Punycode-encoded labels in golang.org/x/net/idna Module: golang.org/x/net Found in: golang.org/x/net@v0.54.0 Fixed in: golang.org/x/net@v0.55.0 Example traces found: #1: internal/testing/require/kubernetes.go: require.KubernetesAtLeast calls discovery.DiscoveryClient.ServerVersion, which eventually calls idna.ToASCII The same scan also reports 18 module-level (uncalled) vulnerabilities, which this bump clears as a side-effect: * 5 more golang.org/x/net/html vulns: GO-2026-5025/5027/5028/5029/5030 (fixed in x/net v0.55.0) * 13 golang.org/x/crypto/ssh* vulns: GO-2026-5005/5006/5013/5014/5015/5016/5017/5018/5019/5020/ GO-2026-5021/5023/5033 (fixed in x/crypto v0.52.0) Compatibility check: * k8s.io/api, k8s.io/apimachinery, k8s.io/client-go @ v0.36.1 each require x/net >= v0.49.0 (we go to v0.55.0) * sigs.k8s.io/controller-runtime @ v0.24.1 requires x/net >= v0.49.0 (we go to v0.55.0) Both bumps are minor patch releases on the golang.org/x/* track, with no breaking changes. 'go mod tidy' additionally bumped x/sys v0.44.0 -> v0.45.0 to satisfy the new x/crypto/x/net requirement. Refs: https://pkg.go.dev/vuln/GO-2026-5026 https://pkg.go.dev/vuln/GO-2026-5005 https://pkg.go.dev/vuln/GO-2026-5023 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
govulncheckworkflow, which is currently red onmainand on every PR (including the otherwise-green #4495 that I just opened). The blocking finding is a single Symbol-level vulnerability in our test helpers that triggers an exit-code-3 fromgovulncheck.Source: https://github.com/CrunchyData/postgres-operator/actions/runs/26296222805/job/77409431501#step:5:180
The same scan additionally reports 18 module-level (uncalled) vulnerabilities, which this bump clears as a side-effect:
golang.org/x/net/htmlvulns (GO-2026-5025/5027/5028/5029/5030) — also fixed inx/net v0.55.0golang.org/x/crypto/ssh*vulns (GO-2026-5005/5006/5013/5014/5015/5016/5017/5018/5019/5020/5021/5023/5033) — fixed inx/crypto v0.52.0Changes
golang.org/x/netv0.54.0->v0.55.0golang.org/x/cryptov0.51.0->v0.52.0golang.org/x/sysv0.44.0->v0.45.0(pulled in transitively bygo mod tidy)No other modules moved. Diff is 6 lines in
go.modand 12 lines ingo.sum.Compatibility
All
k8s.io/*andcontroller-runtimemodules we depend on acceptx/net >= v0.49.0, so this is well within range:k8s.io/api@v0.36.1,apimachinery@v0.36.1,client-go@v0.36.1— requirex/net >= v0.49.0sigs.k8s.io/controller-runtime@v0.24.1— requiresx/net >= v0.49.0Both bumps are minor patch releases on the
golang.org/x/*track, no API changes.Local verification
go mod tidyproduced only the three lines listed abovego build ./cmd/postgres-operatorsucceedsTest plan
govulncheckjob goes greengo-test,golangci-lint,kubernetes-api,kubernetes-k3d,e2e-k3d-chainsaw,e2e-k3d-kuttljobs stay greenvulnerabilitiesjob still greenFollow-up
The same patch should be back-ported to
REL_5_8, which is on the identical vulnerable versions (x/net v0.54.0,x/crypto v0.51.0).Refs
Made with Cursor