Skip to content

Fix missing error handling in WriteUsersInPostgreSQL#4423

Merged
tjmoore4 merged 1 commit intoCrunchyData:mainfrom
balinorLiang:err-handling
Feb 17, 2026
Merged

Fix missing error handling in WriteUsersInPostgreSQL#4423
tjmoore4 merged 1 commit intoCrunchyData:mainfrom
balinorLiang:err-handling

Conversation

@balinorLiang
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

Other Information:
It seems that the error returned by stdout, stderr, err := exec.Exec(...) could be overwritten by err = WriteUsersSchemasInPostgreSQL(ctx, exec, users), so this patch addresses that issue.

Copy link
Contributor

@tjmoore4 tjmoore4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission, @balinorLiang!

@tjmoore4 tjmoore4 merged commit f01925c into CrunchyData:main Feb 17, 2026
21 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants