fix(subdirectory): prefix-safe data-manager dropzone upload icon (24.05 backport)#7671
Merged
ar2rsawseen merged 1 commit intoJun 5, 2026
Merged
Conversation
Backport of the data-manager part of Countly/countly-platform#428 to release.24.05 (ai-assistants/config-transfer are enterprise-only, n/a). Dropzone filename icon used host-root-absolute content: url('/data-manager/images/upload-icon.svg'), which 404s on a subdirectory deploy. Switch to relative url("../images/data-manager/upload-icon.svg") and move the asset images/upload-icon.svg -> images/data-manager/upload-icon.svg so it resolves in both dev and prod layouts. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports a fix to the data-manager plugin so the Dropzone upload filename icon renders correctly when Countly is deployed under a subdirectory (e.g. /countly) by removing a host-root-absolute asset URL and switching to a prefix-safe relative asset path.
Changes:
- Updated the Dropzone filename pseudo-element icon to use a relative
url(..)instead ofurl('/...'). - Added the SVG under
images/data-manager/so the relative reference resolves in both plugin-scoped dev assets and bundled production CSS.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugins/data-manager/frontend/public/stylesheets/main.scss | Replaces host-root-absolute icon URL with a relative path to be subdirectory-safe. |
| plugins/data-manager/frontend/public/images/data-manager/upload-icon.svg | Adds the upload icon asset at the new location referenced by the SCSS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Cookiezaurs
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of the applicable part of Countly/countly-platform#428 to
release.24.05. Of the 3 plugins #428 fixes, only data-manager exists in this repo (ai-assistants / config-transfer are enterprise-only).The data-manager dropzone filename icon used
content: url('/data-manager/images/upload-icon.svg')(host-root-absolute), which 404s on a subdirectory deploy (e.g./countly).Fix
main.scss: relativeurl("../images/data-manager/upload-icon.svg").images/upload-icon.svg→images/data-manager/upload-icon.svgso the relative path resolves in both dev (/data-manager/stylesheets/→/data-manager/images/data-manager/…) and prod (/stylesheets/plugins.min.css→/images/data-manager/…). Referenced only by this scss rule.0 absolute
url("/…")remain; compiled CSS rebuilt by CI.🤖 Generated with Claude Code