test: Verify if .floor is necessary without ActiveRecord::Dirty#24
Closed
test: Verify if .floor is necessary without ActiveRecord::Dirty#24
Conversation
NB : in AR, the cast is done at assignment time. Lets try to do it.
TODO : fix move casting stuff from serialize and place them in cast obviously
And keep unchanged the serialize_value needed for queries (ie find_by_some_time)
- Remove double casting in create_setters to avoid type inconsistencies - Fix Timestamp type precision by applying floor() during cast - Fix DateTimeWith3Decimal precision handling in both cast and serialize 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
Author
|
Was for CI test only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objectif
Tester si le
.floorajouté danslib/couchbase-orm/types/timestamp.rbest vraiment nécessaire ou si c'était un effet de bord de ActiveRecord::Dirty (PR #12).Changements
.floordanslib/couchbase-orm/types/timestamp.rb.floor(3)dansDateTimeWith3Decimal#cast(spec/type_spec.rb)Résultat attendu
.floorétait un effet de bord de AR::Dirty et peut être retiré.floorest nécessaire pour faire passer les testsNote
Cette PR est un test exploratoire en branche depuis
fix_save_return_for_nestedpour valider l'hypothèse avant de finaliser la PR #12.