Skip to content

Lal/add run template v5#59

Open
lalepee wants to merge 21 commits intomainfrom
LAL/add_run_template_v5
Open

Lal/add run template v5#59
lalepee wants to merge 21 commits intomainfrom
LAL/add_run_template_v5

Conversation

@lalepee
Copy link
Contributor

@lalepee lalepee commented Feb 5, 2026

No description provided.

@lalepee lalepee requested a review from csm-thu February 5, 2026 16:06
Copy link
Member

@csm-thu csm-thu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only had time for a quick review, I didn't look at the python code 😅
LGTM if you need to merge it though 👍

from pathlib import Path


# Source - https://stackoverflow.com/a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source link is incomplete

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file seems to be duplicated, it also exists in the "debug" run template. Could we factorize it in a "common" or "utils" folder?

update_dataset_part don't update existing file if you don't set replace_existing at True.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants