Skip to content

more type fixes!#57

Open
sellisd wants to merge 3 commits intomainfrom
DSE/type_validation
Open

more type fixes!#57
sellisd wants to merge 3 commits intomainfrom
DSE/type_validation

Conversation

@sellisd
Copy link
Contributor

@sellisd sellisd commented Jan 30, 2026

I came across a few more issues where strings are not defined as such

@sellisd sellisd requested a review from csm-thu January 30, 2026 14:21
@csm-thu
Copy link
Member

csm-thu commented Jan 30, 2026

@sellisd I can't merge these changes without testing first that it doesn't impact the webapp, but I don't have enough time to check it (also I don't want to disturb the dev environment while we're working to prepare the release 🙂 )

I'll try to have a look at this again after the release of version 7.0.0-rc1

@sellisd
Copy link
Contributor Author

sellisd commented Jan 30, 2026

@sellisd I can't merge these changes without testing first that it doesn't impact the webapp, but I don't have enough time to check it (also I don't want to disturb the dev environment while we're working to prepare the release 🙂 )

I'll try to have a look at this again after the release of version 7.0.0-rc1

Not sure if we actually gain time this way, if there are some bugs it would be better to merge and find them as early as possible. Anyway for now I can use the branch but lets revisit this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants