You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@sellisd I can't merge these changes without testing first that it doesn't impact the webapp, but I don't have enough time to check it (also I don't want to disturb the dev environment while we're working to prepare the release 🙂 )
I'll try to have a look at this again after the release of version 7.0.0-rc1
@sellisd I can't merge these changes without testing first that it doesn't impact the webapp, but I don't have enough time to check it (also I don't want to disturb the dev environment while we're working to prepare the release 🙂 )
I'll try to have a look at this again after the release of version 7.0.0-rc1
Not sure if we actually gain time this way, if there are some bugs it would be better to merge and find them as early as possible. Anyway for now I can use the branch but lets revisit this soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across a few more issues where strings are not defined as such